Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 2021 Utah parameter values #3061

Merged
merged 29 commits into from
Nov 20, 2023
Merged

Add missing 2021 Utah parameter values #3061

merged 29 commits into from
Nov 20, 2023

Conversation

XZ-mabel
Copy link
Collaborator

@XZ-mabel XZ-mabel commented Sep 21, 2023

🤖 Generated by Copilot at 1298b06

Summary

📝🚨🏛️

This pull request updates the Utah retirement credit parameter max in policyengine_us/parameters/gov/states/ut/tax/income/credits/retirement/max.yaml to reflect the current law. It also adds a reference to the source of the parameter value.

To match the current law of the state
We updated the max parameter rate
For the Utah retirement credit
We added a reference to edit
The statute that we can now cite and relate

Walkthrough

  • Update the effective date of the Utah retirement credit to 2021, to match the actual legislation (link)
  • Add a reference to the Utah Code section that defines the retirement credit, to provide a source for the parameter value and the eligibility criteria (link)

Fixes #2180

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36c053c) 99.02% compared to head (22fdc31) 99.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   99.02%   99.03%           
=======================================
  Files        1828     1829    +1     
  Lines       26941    26945    +4     
  Branches      158      157    -1     
=======================================
+ Hits        26678    26684    +6     
+ Misses        225      224    -1     
+ Partials       38       37    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review October 17, 2023 15:20
@MaxGhenis
Copy link
Contributor

tests are failing

@PavelMakarchuk PavelMakarchuk removed the request for review from MaxGhenis November 7, 2023 16:10
retirement credit max test
changelog_entry.yaml Outdated Show resolved Hide resolved
@XZ-mabel XZ-mabel requested a review from MaxGhenis November 14, 2023 16:30
@MaxGhenis MaxGhenis merged commit a7bb52b into PolicyEngine:master Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 2021 Utah retirement credit and taxpayer credit parameters
5 participants