Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC single-joint threshold ratio switch #3046

Merged
merged 8 commits into from
Sep 25, 2023
Merged

Conversation

nikhilwoodruff
Copy link
Collaborator

@nikhilwoodruff nikhilwoodruff commented Sep 19, 2023

Fixes #3045

πŸ€– Generated by Copilot at b35edfe

Summary

πŸ“„πŸ› οΈπŸ”—

This pull request adds a new reform option for DC's income tax that allows adjusting the tax thresholds for joint filers relative to single filers. The reform is defined by a new parameter, a new function, and a new file in the reforms module.

To model DC's income tax
We added a new parameter ratio
It changes the thresholds
For joint filers' wedges
And creates a reform with a bypass

Walkthrough

  • Add a new parameter and a new reform for the ratio of single to joint tax thresholds for DC's income tax (link, link, link, link, link)
  • Create a new parameter file dc_tax_threshold_joint_ratio.yaml with a default value of 1, a description, a unit, and a label (link)
  • Create a new reform file dc_tax_threshold_joint_ratio.py that defines a function to create a reform class that modifies the dc_income_tax_before_credits variable based on the parameter value (link)
  • Import the new reform function in the reforms module (link)
  • Call the new reform function in the create_structural_reforms_from_parameters function, which takes a set of parameters and a period and returns a reform (link)
  • Add a conditional branch to the create_structural_reforms_from_parameters function that returns the new reform if it is not None, otherwise it continues to check for other reforms (link)

@nikhilwoodruff nikhilwoodruff self-assigned this Sep 19, 2023
@nikhilwoodruff
Copy link
Collaborator Author

Needs tests

@MaxGhenis MaxGhenis marked this pull request as draft September 19, 2023 16:02
@MaxGhenis
Copy link
Contributor

Also need to ensure it works in conjunction with the repeal of married filing separately on same return; i.e., to check against filing status

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7362d43) 98.70% compared to head (997eac7) 98.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3046   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files        1706     1706           
  Lines       25714    25714           
  Branches      145      145           
=======================================
  Hits        25382    25382           
  Misses        301      301           
  Partials       31       31           
Files Changed Coverage Ξ”
...come/deductions/itemized/az_itemized_deductions.py 100.00% <ΓΈ> (ΓΈ)

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@nikhilwoodruff nikhilwoodruff marked this pull request as ready for review September 25, 2023 13:17
@MaxGhenis MaxGhenis merged commit 1f403c5 into master Sep 25, 2023
6 checks passed
@MaxGhenis MaxGhenis deleted the nikhilwoodruff/issue3045 branch September 25, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a reform parameter to change the ratio between single and joint tax brackets in DC
2 participants