-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC single-joint threshold ratio switch #3046
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦ax brackets in DC Fixes #3045
Needs tests |
Also need to ensure it works in conjunction with the repeal of married filing separately on same return; i.e., to check against filing status |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3046 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 1706 1706
Lines 25714 25714
Branches 145 145
=======================================
Hits 25382 25382
Misses 301 301
Partials 31 31
β View full report in Codecov by Sentry. |
MaxGhenis
reviewed
Sep 25, 2023
MaxGhenis
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3045
π€ Generated by Copilot at b35edfe
Summary
ππ οΈπ
This pull request adds a new reform option for DC's income tax that allows adjusting the tax thresholds for joint filers relative to single filers. The reform is defined by a new parameter, a new function, and a new file in the
reforms
module.Walkthrough
dc_tax_threshold_joint_ratio.yaml
with a default value of 1, a description, a unit, and a label (link)dc_tax_threshold_joint_ratio.py
that defines a function to create a reform class that modifies thedc_income_tax_before_credits
variable based on the parameter value (link)reforms
module (link)create_structural_reforms_from_parameters
function, which takes a set of parameters and a period and returns a reform (link)create_structural_reforms_from_parameters
function that returns the new reform if it is not None, otherwise it continues to check for other reforms (link)