-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arizona Long-term Capital Gains Subtraction #2994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JudyZ13
changed the title
Add Arizona Net Capital Gains Subtractions
Arizona Net Capital Gains Subtractions
Sep 11, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2994 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 1726 1727 +1
Lines 25950 25963 +13
Branches 145 145
=======================================
+ Hits 25618 25631 +13
Misses 301 301
Partials 31 31
☔ View full report in Codecov by Sentry. |
...ne_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/subtraction_rate.yaml
Outdated
Show resolved
Hide resolved
...ne_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/subtraction_rate.yaml
Outdated
Show resolved
Hide resolved
...ne_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/subtraction_rate.yaml
Outdated
Show resolved
Hide resolved
...ne_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/subtraction_rate.yaml
Outdated
Show resolved
Hide resolved
...ne_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/subtraction_rate.yaml
Outdated
Show resolved
Hide resolved
...s/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtractions.py
Outdated
Show resolved
Hide resolved
...s/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtractions.py
Outdated
Show resolved
Hide resolved
…/net_capital_gains/subtraction_rate.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…/net_capital_gains/subtraction_rate.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…/net_capital_gains/subtraction_rate.yaml Co-authored-by: Pavel Makarchuk <[email protected]>
…net_capital_gains/az_net_capital_gains_subtractions.py Co-authored-by: Pavel Makarchuk <[email protected]>
…engine-us into JudyZ13/issue2993
...es/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
...es/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
...es/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
...es/gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
.../gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.yaml
Outdated
Show resolved
Hide resolved
.../gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.yaml
Outdated
Show resolved
Hide resolved
JudyZ13
changed the title
Arizona Net Capital Gains Subtractions
Arizona Net Capital Gains Subtraction
Sep 13, 2023
.../gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.yaml
Outdated
Show resolved
Hide resolved
.../gov/states/az/tax/income/deductions/net_capital_gains/az_net_capital_gains_subtraction.yaml
Outdated
Show resolved
Hide resolved
…net_capital_gains/az_net_capital_gains_subtraction.py Co-authored-by: Pavel Makarchuk <[email protected]>
…net_capital_gains/az_net_capital_gains_subtraction.py Co-authored-by: Pavel Makarchuk <[email protected]>
Co-authored-by: Pavel Makarchuk <[email protected]>
…engine-us into JudyZ13/issue2993
JudyZ13
changed the title
Arizona Net Capital Gains Subtraction
Arizona Long-term Capital Gains Subtraction
Sep 21, 2023
.../states/az/tax/income/deductions/net_capital_gains/az_long_term_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
…net_capital_gains/az_long_term_capital_gains_subtraction.py
.../states/az/tax/income/deductions/net_capital_gains/az_long_term_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
MaxGhenis
requested changes
Sep 21, 2023
policyengine_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/rate.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/az/tax/income/deductions/net_capital_gains/rate.yaml
Outdated
Show resolved
Hide resolved
.../states/az/tax/income/deductions/net_capital_gains/az_long_term_capital_gains_subtraction.py
Outdated
Show resolved
Hide resolved
…/net_capital_gains/rate.yaml Co-authored-by: Max Ghenis <[email protected]>
…net_capital_gains/az_long_term_capital_gains_subtraction.py Co-authored-by: Max Ghenis <[email protected]>
…engine-us into JudyZ13/issue2993
…itemized/az_itemized_deductions.py
...cyengine_us/variables/gov/states/az/tax/income/deductions/itemized/az_itemized_deductions.py
Outdated
Show resolved
Hide resolved
…engine-us into JudyZ13/issue2993
MaxGhenis
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2993
🤖 Generated by Copilot at 0ba5fa4
Summary
✨📄✅
This pull request adds a new feature to the policy engine: the Arizona net capital gains subtraction. It introduces a new parameter, variable, and test cases for this feature, and updates the changelog accordingly.
Walkthrough
subtraction_rate.yaml
to define the rate of subtraction for different years (link)az_net_capital_gains_subtractions.py
to implement the formula for calculating the subtractions based on the parameter and the tax unit's capital gains (link)az_net_capital_gains_subtractions.yaml
to verify the expected output of the variable for different scenarios (link)