-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
South Carolina retirement deduction #2927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #2927 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 1803 1811 +8
Lines 26610 26703 +93
Branches 158 158
=======================================
+ Hits 26347 26440 +93
Misses 225 225
Partials 38 38
β View full report in Codecov by Sentry. |
..._us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/age_threshold.yaml
Outdated
Show resolved
Hide resolved
..._us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/age_threshold.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/older_amount.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/older_amount.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/older_amount.yaml
Outdated
Show resolved
Hide resolved
...e_us/parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/older_amount.yaml
Outdated
Show resolved
Hide resolved
...income/subtractions/retirement_deduction/sc_military_retirement_income_deduction_survivor.py
Outdated
Show resolved
Hide resolved
...income/subtractions/retirement_deduction/sc_military_retirement_income_deduction_survivor.py
Outdated
Show resolved
Hide resolved
...income/subtractions/retirement_deduction/sc_military_retirement_income_deduction_survivor.py
Outdated
Show resolved
Hide resolved
...income/subtractions/retirement_deduction/sc_military_retirement_income_deduction_survivor.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
add a boolean parameter subtract_military.yaml Fixes PolicyEngine#2926
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
...parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/subtract_military.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/subtract_military.yaml
Outdated
Show resolved
Hide resolved
...parameters/gov/states/sc/tax/income/subtractions/retirement_deduction/subtract_military.yaml
Outdated
Show resolved
Hide resolved
...arameters/gov/states/sc/tax/income/subtractions/retirement_deduction/max_amount/younger.yaml
Outdated
Show resolved
Hide resolved
...s/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_indv.py
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#2926
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
...s/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_indv.py
Outdated
Show resolved
Hide resolved
...s/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_indv.py
Outdated
Show resolved
Hide resolved
...s/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_indv.py
Outdated
Show resolved
Hide resolved
β¦engine-us into hua7450/issue2926
...gov/states/sc/tax/income/subtractions/military_retirement_deduction/sc_military_deduction.py
Outdated
Show resolved
Hide resolved
...iables/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction.py
Outdated
Show resolved
Hide resolved
.../states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_survivors.py
Outdated
Show resolved
Hide resolved
...tates/sc/tax/income/subtractions/military_retirement_deduction/sc_military_deduction_indv.py
Outdated
Show resolved
Hide resolved
...s/gov/states/sc/tax/income/subtractions/retirement_deduction/sc_retirement_deduction_indv.py
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#2926 Co-authored-by: Pinyan <[email protected]>
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
MaxGhenis
requested changes
Nov 6, 2023
...iables/gov/states/sc/tax/income/subtractions/retirement/sc_retirement_deduction_survivors.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/subtractions/retirement/age_threshold.yaml
Outdated
Show resolved
Hide resolved
...engine_us/parameters/gov/states/sc/tax/income/subtractions/retirement/subtract_military.yaml
Outdated
Show resolved
Hide resolved
...engine_us/parameters/gov/states/sc/tax/income/subtractions/retirement/subtract_military.yaml
Outdated
Show resolved
Hide resolved
...bles/gov/states/sc/tax/income/subtractions/military_retirement/sc_military_deduction_indv.py
Show resolved
Hide resolved
policyengine_us/variables/household/income/person/pensions/military_retirement_pay_survivors.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
MaxGhenis
requested changes
Nov 7, 2023
...iables/gov/states/sc/tax/income/subtractions/retirement/sc_retirement_deduction_survivors.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/subtractions/retirement/cap.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/sc/tax/income/subtractions/retirement/cap.yaml
Outdated
Show resolved
Hide resolved
add more test cases Fixes PolicyEngine#2926
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
MaxGhenis
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2926
Co-authored-by: Pinyan [email protected]
π€ Generated by Copilot at 3e891c2
Summary
πποΈπ
This pull request adds new parameters, variables, and tests for state income tax subtractions in Colorado and South Carolina. It implements the logic and data for the Colorado charitable deduction, the Colorado CollegeInvest contribution deduction, and the South Carolina retirement deduction. It also adds a special deduction for the surviving spouse of a military retiree who died in the line of duty in South Carolina. It updates the relevant files in the
parameters
,variables
, andtests
folders.Walkthrough