Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

South Carolina retirement deduction #2927

Merged
merged 33 commits into from
Nov 8, 2023

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Aug 31, 2023

Fixes #2926

Co-authored-by: Pinyan [email protected]

πŸ€– Generated by Copilot at 3e891c2

Summary

πŸŽ“πŸŽ—οΈπŸŽ

This pull request adds new parameters, variables, and tests for state income tax subtractions in Colorado and South Carolina. It implements the logic and data for the Colorado charitable deduction, the Colorado CollegeInvest contribution deduction, and the South Carolina retirement deduction. It also adds a special deduction for the surviving spouse of a military retiree who died in the line of duty in South Carolina. It updates the relevant files in the parameters, variables, and tests folders.

Colorado, SC
New parameters and tests
Autumn of updates

Walkthrough

  • Add new parameter files for Colorado and South Carolina state income tax subtractions (link, link, link, link, link)
  • Add new variable files for Colorado and South Carolina state income tax subtractions (link, link, link, link, link)
  • Add new test files for Colorado and South Carolina state income tax subtractions (link, link, link)

@pxu12 pxu12 added the states/sc South Carolina label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (7a15b79) 99.01% compared to head (e83a274) 99.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2927   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files        1803     1811    +8     
  Lines       26610    26703   +93     
  Branches      158      158           
=======================================
+ Hits        26347    26440   +93     
  Misses        225      225           
  Partials       38       38           
Files Coverage Ξ”
...tions/military_retirement/sc_military_deduction.py 100.00% <100.00%> (ΓΈ)
.../military_retirement/sc_military_deduction_indv.py 100.00% <100.00%> (ΓΈ)
...tary_retirement/sc_military_deduction_survivors.py 100.00% <100.00%> (ΓΈ)
...ncome/subtractions/retirement/sc_retirement_cap.py 100.00% <100.00%> (ΓΈ)
...subtractions/retirement/sc_retirement_deduction.py 100.00% <100.00%> (ΓΈ)
...actions/retirement/sc_retirement_deduction_indv.py 100.00% <100.00%> (ΓΈ)
...ns/retirement/sc_retirement_deduction_survivors.py 100.00% <100.00%> (ΓΈ)
...rson/pensions/military_retirement_pay_survivors.py 100.00% <100.00%> (ΓΈ)

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@hua7450 hua7450 marked this pull request as ready for review October 3, 2023 23:58
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2926
@hua7450 hua7450 requested a review from MaxGhenis November 8, 2023 19:51
@MaxGhenis MaxGhenis merged commit bde439b into PolicyEngine:master Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
states/sc South Carolina
Projects
None yet
Development

Successfully merging this pull request may close these issues.

South Carolina retirement deduction & military retirement deduction
4 participants