-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
South Carolina Net Capital Gain Deduction #2718
Merged
PavelMakarchuk
merged 26 commits into
PolicyEngine:master
from
hua7450:hua7450/issue2716
Oct 4, 2023
Merged
South Carolina Net Capital Gain Deduction #2718
PavelMakarchuk
merged 26 commits into
PolicyEngine:master
from
hua7450:hua7450/issue2716
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PolicyEngine#2716 Co-authored-by: Pinyan <[email protected]>
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2718 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 1726 1727 +1
Lines 25950 25963 +13
Branches 145 145
=======================================
+ Hits 25618 25631 +13
Misses 301 301
Partials 31 31
☔ View full report in Codecov by Sentry. |
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
LeqiGogo
reviewed
Aug 14, 2023
...gine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gains_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
LeqiGogo
reviewed
Aug 14, 2023
...gine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gains_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
LeqiGogo
reviewed
Aug 14, 2023
...s/sc/tax/income/deductions/net_captial_gains_deductions/sc_net_capital_gains_deductions.yaml
Outdated
Show resolved
Hide resolved
LeqiGogo
reviewed
Aug 14, 2023
...states/sc/tax/income/deductions/net_capital_gains_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
LeqiGogo
reviewed
Aug 14, 2023
...gine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gains_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
martinholmer
added
enhancement
New feature or request
tax
Federal and state tax policy
states/sc
South Carolina
labels
Aug 29, 2023
...states/sc/tax/income/deductions/net_capital_gains_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
Fixes PolicyEngine#2716
...gine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gains_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
…/net_capital_gains_deduction/rate.yaml
...gine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gains_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
...states/sc/tax/income/deductions/net_capital_gains_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
...states/sc/tax/income/deductions/net_capital_gains_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
...states/sc/tax/income/deductions/net_capital_gains_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
…engine-us into hua7450/issue2716
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
.../states/sc/tax/income/deductions/net_capital_gain_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
.../states/sc/tax/income/deductions/net_capital_gain_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
.../states/sc/tax/income/deductions/net_capital_gain_deduction/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
use net_capital_gain to replace capital_gain Fixes PolicyEngine#2716
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
PavelMakarchuk
approved these changes
Sep 9, 2023
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
MaxGhenis
requested changes
Sep 21, 2023
...ngine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gain_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
MaxGhenis
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge after this
...ngine_us/parameters/gov/states/sc/tax/income/deductions/net_capital_gain_deduction/rate.yaml
Outdated
Show resolved
Hide resolved
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
...iables/gov/states/sc/tax/income/deductions/net_capital_gain/sc_net_capital_gain_deduction.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write code on South Carolina Net Capital Gain Deduction