Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

South Carolina Net Capital Gain Deduction #2718

Merged
merged 26 commits into from
Oct 4, 2023

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Jul 27, 2023

Write code on South Carolina Net Capital Gain Deduction

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e0a95ba) 98.72% compared to head (1dfd0e0) 98.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2718   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files        1726     1727    +1     
  Lines       25950    25963   +13     
  Branches      145      145           
=======================================
+ Hits        25618    25631   +13     
  Misses        301      301           
  Partials       31       31           
Files Coverage Δ
.../net_capital_gain/sc_net_capital_gain_deduction.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinholmer martinholmer added enhancement New feature or request tax Federal and state tax policy states/sc South Carolina labels Aug 29, 2023
@hua7450 hua7450 requested a review from PavelMakarchuk August 30, 2023 23:32
use net_capital_gain to replace capital_gain
Fixes PolicyEngine#2716
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review September 10, 2023 15:43
Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us into hua7450/issue2716
@hua7450 hua7450 requested a review from MaxGhenis October 3, 2023 23:58
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after this

@PavelMakarchuk PavelMakarchuk merged commit 0b6593d into PolicyEngine:master Oct 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request states/sc South Carolina tax Federal and state tax policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants