Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZ itemized deduction #2571

Merged
merged 62 commits into from
Sep 24, 2023
Merged

AZ itemized deduction #2571

merged 62 commits into from
Sep 24, 2023

Conversation

phywzc
Copy link
Contributor

@phywzc phywzc commented Jul 4, 2023

🤖 Generated by Copilot at b2c3209

Summary

📝📄📐

This pull request adds support for the Arizona itemized deduction adjustment for state income taxes, which is a feature of the Arizona tax system that affects the state income tax liability of filers who itemize their deductions. It creates a new parameter file limit_from_federal_schedule_a.yaml and a new variable file az_itemized_deduction_adjustments.py to implement the adjustment logic based on the 2022 Form 140 Schedule A.

Arizona tax
Adjusting itemized deductions
New files in YAML

Walkthrough

  • Add a new variable and parameter for the Arizona itemized deduction adjustment for state income taxes (link, link)
  • Add an empty line to the changelog entry file (link)

Fixes #2527

@PavelMakarchuk PavelMakarchuk marked this pull request as ready for review July 20, 2023 14:34
@PavelMakarchuk PavelMakarchuk self-requested a review July 20, 2023 14:34
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (eeef18c) 98.70% compared to head (1e3a9b9) 98.70%.
Report is 23 commits behind head on master.

❗ Current head 1e3a9b9 differs from pull request most recent head bd78405. Consider uploading reports for the commit bd78405 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2571   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files        1701     1705    +4     
  Lines       25639    25696   +57     
  Branches      144      145    +1     
=======================================
+ Hits        25307    25364   +57     
  Misses        301      301           
  Partials       31       31           
Files Changed Coverage Δ
...contribution/az_charitable_contributions_credit.py 100.00% <100.00%> (ø)
...ibutions_to_qualifying_charitable_organizations.py 100.00% <100.00%> (ø)
...butions_to_qualifying_foster_care_organizations.py 100.00% <100.00%> (ø)
...come/deductions/itemized/az_itemized_deductions.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

phywzc and others added 9 commits July 25, 2023 05:01
…itemized/az_total_itemized_deduction_allowed_by_irs.py

Co-authored-by: Pavel Makarchuk <[email protected]>
…itemized/az_total_itemized_deduction_allowed_by_irs.py

Co-authored-by: Pavel Makarchuk <[email protected]>
…itemized/az_total_itemized_deduction_allowed_by_irs.py

Co-authored-by: Pavel Makarchuk <[email protected]>
…itemized/az_total_itemized_deduction_allowed_by_irs.py

Co-authored-by: Pavel Makarchuk <[email protected]>
…itemized/az_itemized_deduction_adjustments.py

Co-authored-by: Pavel Makarchuk <[email protected]>
changelog.yaml Outdated Show resolved Hide resolved
@phywzc phywzc requested a review from MaxGhenis September 6, 2023 04:37
@MaxGhenis
Copy link
Contributor

Please resolve outstanding comment threads if they're addressed

@phywzc phywzc closed this Sep 6, 2023
@phywzc phywzc reopened this Sep 6, 2023
@phywzc phywzc requested a review from MaxGhenis September 22, 2023 05:21
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after these

@phywzc phywzc requested a review from MaxGhenis September 24, 2023 11:40
@MaxGhenis MaxGhenis merged commit 1529be4 into PolicyEngine:master Sep 24, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arizona Itemized Deduction
4 participants