Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy output info modal appears every time #2026

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

nikhilwoodruff
Copy link
Contributor

Fixes #2025

cc @anth-volk

@nikhilwoodruff nikhilwoodruff added the bug Something isn't working label Sep 24, 2024
@nikhilwoodruff nikhilwoodruff self-assigned this Sep 24, 2024
@anth-volk
Copy link
Collaborator

@nikhilwoodruff Could you remove the unused import of setCookie?

@anth-volk
Copy link
Collaborator

I'm sorry, I meant the import {..., setCookie} in PolicyImpactPopup, but it's fine, I can take it out

@anth-volk
Copy link
Collaborator

Your changes just kind of ripped the entire function out

@anth-volk anth-volk force-pushed the nikhilwoodruff/issue2025 branch from 485744e to e989da8 Compare September 25, 2024 23:39
@anth-volk anth-volk merged commit d550b66 into master Sep 25, 2024
2 checks passed
@anth-volk anth-volk deleted the nikhilwoodruff/issue2025 branch September 25, 2024 23:46
@nikhilwoodruff
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Policy output info modal appears every time
2 participants