Add JSON schemas #291
Open
Add JSON schemas #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adback03 could I get a review on this? thanks in advance! |
|
Any updates on this? This looks pretty useful to me. |
|
Would it help if I added also a GitHub action to check that any change is correct w.r.t. the schemas? |
|
Can you include a script used to generate the file? Since many of the enum fields are dynamic, they could change frequently. |
|
@adback03 I used an online generator from one of them, and then run What I could do is to add a GitHub Action which checks that files pass the schema validation, and reject the PR if they don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful to check for small typos, and also to auto-generate readers in many programming languages.