improved stepper that walks using Google Directions API #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great work. It would make things much easier if your PR actually described the problem you are trying to solve and your changes. Having many PRs that just say Polyline isn't very helpful to reviewers |
th3w4y
changed the title
|
Cloud you rebase your commits, and merge them into one commit? |
|
@jtdroste Thanks for the suggestion - i just learned how to do it now |
| proposed_origin = polyline_walker.points[0] | ||
| proposed_destination = polyline_walker.points[-1] | ||
| proposed_lat = proposed_origin[0] | ||
| proposed_lng = proposed_origin[1] | ||
| if proposed_lat != lat and proposed_lng != lng: | ||
| logger.log('[#] Using _old_walk_to to go to the proposed_origin: ' +str(proposed_origin)) |
|
Test code, not called, so merged. |
MFizz
pushed a commit
to MFizz/PokemonGo-Bot
that referenced
this pull request
Jul 29, 2016
* improved stepper that walks using Google Directions API * improved logging
hoanghuynh
pushed a commit
to hoanghuynh/PokemonGo-Bot
that referenced
this pull request
Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
In order to try it, add below lines to pokecli.py
Fixes: