Fixing ITEM_FILTER and Attribute Error: no position Issues #638
Conversation
|
we won't, we need fix CI error first. |
|
Now working @solderzzc just notifying, I know you need to fix CI errors first |
| @@ -163,7 +163,7 @@ This project uses Google Maps. There's one map coupled with the project, but as | |||
| -it, --initial_transfer Transfer all duplicate pokemon with same ID on bot start, except pokemon with highest CP. Accepts a number to prevent transferring pokemon with a CP above the provided value. Default is 0 (aka transfer none). | |||
| -ms, --max_steps MAX_STEP Set the steps around your initial location (DEFAULT 5 mean 25 cells around your location) | |||
| -iv IV, --pokemon_potential Set the ratio for the IV values to transfer (DEFAULT 0.4 eg. 0.4 will transfer a pokemon with IV 0.3) | |||
| -if LIST, --item_filter LIST Pass a list of unwanted items to recycle when collected at a Pokestop (e.g, \"101,102,103,104\" to recycle potions when collected)" | |||
There was a problem hiding this comment.
We can not keep changing the config.json format time by time... It's huge work to solve users question in slack help channel.
There was a problem hiding this comment.
it's not changing it, people were still using it both ways, but one way was causing unexpected behavior
|
@solderzzc Here you go :) down to 2 commits, I tested it earlier but can't test it now as dev branch is unstable. The changes don't change the way arguments work, it just corrects unwanted behavior for users that misunderstood how to use the feature |
dmateusp
changed the title
|
Will it break current users' configuration ? If so, need add it to the breaking thing in README. |
|
@solderzzc it won't, see the initial configuration was ["101","102","103","104"] as an example to filter out potions, but people used it as "101,102,103,104" but the app would still run and filter out everything. So I just changed the logic so both syntaxes are now correct and have the expected behavior |
| else: | ||
| pass | ||
| sys.exit( | ||
| "No cached Location. Please specify initial location.") | ||
|
|
||
| def _get_pos_by_name(self, location_name): | ||
| # Check if the given location is already a coordinate. |
There was a problem hiding this comment.
release_config.json.example → release_config.json
This should not be tracked.
Invitation sent, please join our team.
There was a problem hiding this comment.
You are more than welcome.
…F#638) * FIXING filter_item issues * FIXING filter_item issues * FIXING filter_item issues * FIXING filter_item issues * fixing no position Attribute found * Fixing Filter_item issues, and no attribute position * Delete release_config.json
Fixes:
Please note that I implemented this feature so my commit is more relevant than other fixes that do not understand the code