Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI improvements and updates #623

Closed
wants to merge 26 commits into from
Closed

Web UI improvements and updates #623

wants to merge 26 commits into from

Conversation

glennvgastel
Copy link
Contributor

Short Description:

Updates to pokemon bag display on the map

Fixes:

  • Added CP and IV to caught pokemon on map
  • Improved layout for pokemon bag display on map

@jadbalout
Copy link

Nice work, though all those ??? on the eggs makes it look bad. Maybe work out a way to remove the display of those field for eggs?

@glennvgastel
Copy link
Contributor Author

Good idea. I'm also looking into a way to sort the pokemon by name or CP level, will add that soon.

@jadbalout
Copy link

How about both? ;) Add sorting options mate.

@glennvgastel
Copy link
Contributor Author

Sorting is coming up.

@elicwhite
Copy link
Contributor

Screenshots for UI changes are helpful

@Tiokun
Copy link

Tiokun commented Jul 24, 2016

sorting would be really nice :) im running this code atm

https://gyazo.com/d98b895f14baba667679985aff3548a4

@glennvgastel
Copy link
Contributor Author

Sorting has been added and the eggs in your bag are now displayed below your pokemon as "You have x eggs".

sorting_options

@RedSparr0w
Copy link

Nice work, one more thing though.

Line 366 - 375 Change to

 if (menu == 2) {
    document.getElementById('subtitle').innerHTML = "Items in Bag";
    out = '<div class="row items"><div class="col s12"><h5>' + users[0] + '</h5><table>';
    for (var i = 0; i < bagItems.length; i++) {
      out += '<tr><td><img src="image/items/' + bagItems[i].inventory_item_data.item.item_id + '.png" class="item_img"></td><td>Item: ' + itemsArray[bagItems[i].inventory_item_data.item.item_id] +
      '<br>Count: ' + (bagItems[i].inventory_item_data.item.count || 0) + '</td></tr>';
    }
    out += '</table></div></div>';
    document.getElementById('subcontent').innerHTML = out;
  }

@glennvgastel
Copy link
Contributor Author

@RedSparr0w Added.

@glennvgastel
Copy link
Contributor Author

glennvgastel commented Jul 24, 2016

Improved responsiveness, items in bag layout and restyled the menu options

ui-changes-mobile

ui-changes-desktop

@glennvgastel glennvgastel changed the title Updates to pokemon bag display on the map Web UI improvements and updates Jul 24, 2016
@glennvgastel
Copy link
Contributor Author

I'm going to rebase and create a new PR, this is starting to become a mess :D

@RedSparr0w
Copy link

RedSparr0w commented Jul 24, 2016

Coming along nicely.

One more thing if you think it would work/have the time.

Could you add a little pokeball icon next to each pokemon in your bag showing which pokeball it was caught with?

snippets of code:

pkmPokeball = obj[i].inventory_item_data.pokemon_data.pokeball || 0;
<img src="/image/items/' + pkmPokeball + '.png" class="pokeball">
.pokeball {
    width: 30px;
    height: auto;
}

if it is a starter pokemon it will show: (0.png)

not sure about eggs though as haven't hatched one yet.

edit: looks like web has moved

@glennvgastel
Copy link
Contributor Author

@RedSparr0w I've merged my sorting code with the design Sniok created in the new repository.
You can see the PR here : tehp/OpenPoGoWeb#17 along with a screenshot.

I'll add the pokeball tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.