-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI improvements and updates #623
Conversation
Nice work, though all those ??? on the eggs makes it look bad. Maybe work out a way to remove the display of those field for eggs? |
Good idea. I'm also looking into a way to sort the pokemon by name or CP level, will add that soon. |
How about both? ;) Add sorting options mate. |
Sorting is coming up. |
* zero means out of stock ;) * typo in variable
… to avoid check. The file is not use for now.
* Refactor: Moving evolve logic out of the stepper
Screenshots for UI changes are helpful |
sorting would be really nice :) im running this code atm |
Nice work, one more thing though. Line 366 - 375 Change to if (menu == 2) {
document.getElementById('subtitle').innerHTML = "Items in Bag";
out = '<div class="row items"><div class="col s12"><h5>' + users[0] + '</h5><table>';
for (var i = 0; i < bagItems.length; i++) {
out += '<tr><td><img src="image/items/' + bagItems[i].inventory_item_data.item.item_id + '.png" class="item_img"></td><td>Item: ' + itemsArray[bagItems[i].inventory_item_data.item.item_id] +
'<br>Count: ' + (bagItems[i].inventory_item_data.item.count || 0) + '</td></tr>';
}
out += '</table></div></div>';
document.getElementById('subcontent').innerHTML = out;
} |
@RedSparr0w Added. |
Better responsiveness Items in bag layout improved
# Conflicts: # web/main.js
I'm going to rebase and create a new PR, this is starting to become a mess :D |
Coming along nicely. One more thing if you think it would work/have the time. Could you add a little pokeball icon next to each pokemon in your bag showing which pokeball it was caught with? snippets of code: pkmPokeball = obj[i].inventory_item_data.pokemon_data.pokeball || 0; <img src="/image/items/' + pkmPokeball + '.png" class="pokeball"> .pokeball {
width: 30px;
height: auto;
} if it is a starter pokemon it will show: (0.png) not sure about eggs though as haven't hatched one yet. edit: looks like web has moved |
@RedSparr0w I've merged my sorting code with the design Sniok created in the new repository. I'll add the pokeball tomorrow. |
Short Description:
Updates to pokemon bag display on the map
Fixes: