Added only_catch_better_iv and only_catch_better_cp

[davidakachaos]

Added ability for the bot to do a basic check if a Pokemon to be caught is a higher IV or CP than the one we have (highest one we have) and see if we need to try and catch it.

[mention-bot]

@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @supercourgette, @TheSavior and @pokepal to be potential reviewers.

[MerlionRock]

I don't understand the need of this... Just catch... Can earn some stardust... Later use optimizer to release... This sound redundant....

[davidakachaos]

Agreed, but look at #6154 why someone wants to change catch parameters all the time

[Jcolomar]

this is better than #6154

[Jcolomar]

works only around IV and CP, but only see pokemon_id? or also family_id?

[goedzo]

I am not liking the way this is coded:

if pokemon_config.get('only_catch_better_cp', False):

This will fail if the key is missing in json. So we need to avoid config fails whenever something new is added. Please default the values and allow the key not to be in config.

[davidakachaos]

This will fail if the key is missing in json.

It doesn't with me? I believe I provide a default value with the False here, so if no value found it will default to False?

[davidakachaos]

@Jcolomar it works based on a Pokemon, not on a family of Pokemon, so no family_id

[goedzo]

@davidakachaos sorry missed the false there :).

[Jcolomar]

@davidakachaos so u need a rule for each pokemon...

[davidakachaos]

Yes, I mean this rule isn't for every Pokémon? Like the candy rule, it works like that, so it checks the Pokémon about to be caught versus the rule(s) matched, so it would be able to match multiple Pokémon? Op 1 aug. 2017 14:38 schreef "Jhero" <[email protected]>:

…

@davidakachaos <https://github.com/davidakachaos> so u need a rule for each pokemon... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD5Y3xxA3__ruEOtTVV-VwAsN3blob5ks5sTxxIgaJpZM4OnZPX> .

[solderzzc]

@davidakachaos @Jcolomar You want to merge this pr?

[Jcolomar]

Ya np. We kept opened coz @davidakachaos is in vacation.