Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed logic to check if move_to_fort is stuck #6153

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

ChiefM3
Copy link
Contributor

@ChiefM3 ChiefM3 commented Jul 27, 2017

Short Description:

  • The existing logic to check if the bot was stuck was to compare the current distance to fort with the previous 5 distances to fort and say that it's stuck if there was 1 match.
  • This would lead to a false positive very often because of the noise when the bot is set to move rather slow.
  • I changed the logic to compare the previous 1-5 distances to fort vs previous 6-10 distances to fort to see the trend instead of a specific value. So if the trend is decreasing, the error_moving = True will not be triggered.

Fixes/Resolves/Closes (please use correct syntax):

@MerlionRock
Copy link
Contributor

MerlionRock commented Jul 27, 2017

👍

Approved with PullApprove

@MerlionRock
Copy link
Contributor

Let's test it

@MerlionRock MerlionRock merged commit b3d7b4f into PokemonGoF:dev Jul 27, 2017
@ChiefM3 ChiefM3 deleted the fix_difficulty_walking branch July 27, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants