Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting HP of Pokemon #6024

Merged
merged 1 commit into from
Apr 22, 2017
Merged

Correcting HP of Pokemon #6024

merged 1 commit into from
Apr 22, 2017

Conversation

davidakachaos
Copy link
Contributor

Before the change if a Pokemon has 0 HP, it will be set to the Max HP.
This corrects this, setting HP to 0 when a Pokemon is dead/fainted.

If HP is zero, the Pokemon is dead/fainted. Dont set it to Max HP
@mention-bot
Copy link

@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amal, @BriceSD and @aeckert to be potential reviewers.

@davidakachaos davidakachaos changed the base branch from master to dev April 21, 2017 08:50
@Jcolomar Jcolomar merged commit 03cfee3 into PokemonGoF:dev Apr 22, 2017
@davidakachaos davidakachaos deleted the correct_hp branch August 23, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants