Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using proxy with docker #6010

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Using proxy with docker #6010

merged 1 commit into from
Apr 10, 2017

Conversation

lepeli
Copy link
Contributor

@lepeli lepeli commented Apr 10, 2017

Adding how to use a proxy with docker

Please Note - You may remove this section before opening your PR

We receive lots of PRs and it is hard to give proper review to PRs. Please make it easy on us by following these guidelines:

  1. We do not accept changes to master. Please make sure your pull request is aimed at dev.
  2. If you changed a bunch of files (that aren't config files) or multiple workers to implement your feature, it probably won't get proper attention. Please split it up into multiple, smaller, more focused, and iterative PRs if you can.
  3. If you are adding a config value to something, make sure you update the appropriate config.json example files.
  4. If your pull request is fixing / resolving / or closing any of the issues, please ensure the correct syntax is used eg: Closes #X, Fixes#Y

Short Description:

I just added a section for using a proxy with docker

Fixes/Resolves/Closes (please use correct syntax):

  • Change on installation documentation

Adding how to use a proxy with docker
@mention-bot
Copy link

@lepeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nivong, @walkerlee and @supercourgette to be potential reviewers.

@pogarek
Copy link
Contributor

pogarek commented Apr 10, 2017

👍

Approved with PullApprove

@pogarek pogarek merged commit 48cd041 into PokemonGoF:dev Apr 10, 2017
@pogarek
Copy link
Contributor

pogarek commented Apr 10, 2017

merged #6010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants