Sniper fixes

[davidakachaos]

Short Description:

Fixes for these issues I noticed:

• Fixes an issue with a source hiding latitude and longitude of Pokemons when using it without a subscription.
• Also converts IV to float instead of an integer. Some sites use IVs like 96.7
• Adds a cooldown to sniping, to prevent Niantic from seeing you jumping all over the world 😄
• Fixes an logic issue, where sniper would snipe Pokemon below the special IV instead of that and above.

GitHub Selfies

[mention-bot]

@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @YvesHenri, @Gobberwart and @MerlionRock to be potential reviewers.

[MerlionRock]

Wondering how does cool down prevent Niantic not seeing you jumping around the world.... Lol....

[davidakachaos]

It was an idea I had; after sniping Niantic might "flag" an account to be more closely monitored. Nothing based on proof, just feeling like something I would do when I was combatting bots...
And no, it wouldn't prevent it, but it does screw with a detecting strat to see if some accounts are sniping...
I would be happy to remove the cooldown if you think it has no use at all 😉

[pogarek]

I think it would be good to expose cooldown to config.json , with default behavior like it was before the PR. :) Plus, of course, a proper modification to sample config and docs :)

[davidakachaos]

@pogarek Done 😉

[pogarek]

👍
let's test it out on dev :) However I'll stick with my current config. Works for a last few months :-P

[pogarek]

merged #5962