Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunter and camping forts changes #5940

Merged
merged 3 commits into from
Mar 3, 2017

Conversation

davidakachaos
Copy link
Contributor

CampForts

  • Corrected a flow bug
  • Added rechecking of biggest cluster in range
  • Notes other task of camping active

PokemonHunter:

Config

  • Added config "lock_vip_only" to only lock VIP pokemon, not if only completing Pokedex
  • Added config "disabled_while_camping" to disable hunting if the bot is camping at lured forts
  • Added config "treat_unseen_as_vip" to toggle if unseen Pokemon are VIP for hunting or not

Behaviour

  • Checks if a hunted Pokemon was caught recently
  • Takes a break from hunting after a hunt. More human like behaviour
  • Picks a random Pokemon to hunt down. More human like behaviour
  • Lists Pokemon around with number instead of repeatedly in a list
  • If unable to move to a hunted Pokemon, abort the search and start a cooldown
  • Needed for Pokedex will now return False if amount of candies is above 150
  • Uses the database of caught Pokemon to check if our hunted Pokemon was caught.

Used to see if we ignore this Pokemon or not
- Corrected a flow bug
- Added rechecking of biggest cluster in range
- Notes other task of camping active
- Added config "lock_vip_only" to only lock VIP pokemon, not if only completing Pokedex
- Added config "disabled_while_camping" to disable hunting if the bot is camping at lured forts
- Added config "treat_unseen_as_vip" to toggle if unseen Pokemon are VIP for hunting or not

Behaviour:
- Checks if a hunted Pokemon was caught recently
- Takes a break from hunting after a hunt. More human like behaviour
- Picks a random Pokemon to hunt down. More human like behaviour
- Lists Pokemon around with number instead of repeatedly in a list
- If unable to move to a hunted Pokemon, abort the search and start a cooldown
- Needed for Pokedex will now return False if amount of candies is above 150
- Uses the database of caught Pokemon to check if our hunted Pokemon was caught.
@mention-bot
Copy link

@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mjmadsen, @anakin5 and @RedViper9 to be potential reviewers.

@davidakachaos davidakachaos changed the base branch from master to dev March 3, 2017 09:25
@pogarek
Copy link
Contributor

pogarek commented Mar 3, 2017

looks nice. let's test on dev. testing also if I can approve :)
👍

Approved with PullApprove

@pogarek pogarek merged commit bf92bf4 into PokemonGoF:dev Mar 3, 2017
@pogarek
Copy link
Contributor

pogarek commented Mar 3, 2017

Merged #5940

@davidakachaos
Copy link
Contributor Author

And look at that 😄 you can approve 👍

@pogarek
Copy link
Contributor

pogarek commented Mar 3, 2017

Yes , I can :) It would be good to adjust config examples

@davidakachaos
Copy link
Contributor Author

Yes, I'm doing that right now

@MerlionRock
Copy link
Contributor

Nice :) hopefully this project can go back to its former glory. Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants