Fix ValueError crash #5800
Merged
Fix ValueError crash #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValueError, "non-integer arg 1 for randrange()"
|
@Gobberwart, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mudmud2k, @douglascamata and @TheSavior to be potential reviewers. |
mmixx
approved these changes
Nov 9, 2016
|
Instead of random.randint it also could use random.uniform, so there is no need for helping variables or an int converting... Sorry that I forgot to add the int() and missed the int/float-error, it should had been:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
FIxes bot crash introduced by PR #5704.
ValueError, "non-integer arg 1 for randrange()"Error is caused by trying to pass FLOATs to the randrange function instead of INTs.
Does not happen when reconnecting_timeout in config is set to default 15, as 15 * 0.8 = 12, and 15 * 1.2 = 18, so both are INTs, however if reconnecting_timeout is changed from the default, this error occurs.