When daily spin limit is reached, let it continue working instead of … #5550

kolinkorr839 · 2016-09-19T19:50:24Z

Short Description:

When the daily spin limit is reached, the script exits. This change allow the script to continue but gives a warning that the spin limit is reached every 120 seconds (default which can be changed).

Sample output:

[2016-09-19 11:54:53] [  SpinFort] [INFO] Spun pokestop First Street. Experience awarded: 50. Items awarded: 1x Potion, 2x Pokeball
[2016-09-19 11:54:53] [  SpinFort] [INFO] WARNING! You have reached your daily spin limit
[2016-09-19 11:54:58] [MoveToFort] [INFO] Moving towards pokestop Mosaic Seats - 0.07km
[2016-09-19 11:55:03] [MoveToFort] [INFO] Moving towards pokestop Mosaic Seats - 0.06km
[2016-09-19 11:55:09] [MoveToFort] [INFO] Moving towards pokestop Mosaic Seats - 0.04km
[2016-09-19 11:55:10] [  SpinFort] [INFO] Spun pokestop Mosaic Seats. Experience awarded: 50. Items awarded: 3x Pokeball

mention-bot · 2016-09-19T19:50:26Z

@kolinkorr839, thanks for your PR! By analyzing the annotation information on this pull request, we identified @askovpen, @douglascamata and @BriceSD to be potential reviewers

solderzzc · 2016-09-19T22:53:24Z

It's better to add an option to allow user decide if quit when hit daily limit.
The daily limit is a very good protection.

Gobberwart · 2016-09-20T01:32:49Z

pokemongo_bot/cell_workers/spin_fort.py

-                    sys.exit(2)
+                   if datetime.now() >= self.next_update:
+                       self.emit_event('spin_limit', formatted='WARNING! You have reached your daily spin limit')
+                       self._compute_next_update()


Should stop running work here. Maybe add return WorkerResult.ERROR (or SUCCESS depending on your interpretation of this result)

Running is done by MoveToFort or FollowSpiral etc., not by SpinFort. I am also not sure whether returning ERROR here would count towards softban detection... So returning SUCCESS is probably the most nonintrusive way.

Plus - sometimes, you want actually to continue running and apturing pokemons and sniping even with a reached daily limit.

I added a new variable called 'bypass_daily_limit'. This is "false" by default and if the daily_spin_limit is reached, the code will exit. This is the current behavior.

But if the 'bypass_daily_limit' is set to true and the daily_spin_limit is reached, the bot will continue its business but it will give a warning message that the daily spin limit has been reached every 120 seconds (through the min_interval variable which can be changed).

Gobberwart

Only one minor issue. Please add something to break out of work method if daily limit reached (eg. return WorkerResult.ERROR/SUCCESS)

DBa2016

New parameter, needs at the very least to be documented in "config.json.sample" and in "configuration_files.md" - also I suggest renaming it to be more descriptive.

DBa2016 · 2016-09-20T08:54:06Z

pokemongo_bot/cell_workers/spin_fort.py

-                    sys.exit(2)
+                   if datetime.now() >= self.next_update:
+                       self.emit_event('spin_limit', formatted='WARNING! You have reached your daily spin limit')
+                       self._compute_next_update()


Running is done by MoveToFort or FollowSpiral etc., not by SpinFort. I am also not sure whether returning ERROR here would count towards softban detection... So returning SUCCESS is probably the most nonintrusive way.

Plus - sometimes, you want actually to continue running and apturing pokemons and sniping even with a reached daily limit.

DBa2016 · 2016-09-20T08:57:19Z

pokemongo_bot/cell_workers/spin_fort.py

        self.ignore_item_count = self.config.get("ignore_item_count", False)
        self.spin_wait_min = self.config.get("spin_wait_min", 2)
        self.spin_wait_max = self.config.get("spin_wait_max", 3)
+        self.min_interval = int(self.config.get('min_interval', 120))


I suggest renaming "min_interval" to something more descriptive. Maybe "pause_on_daily_limit" or similar.

Also, it needs documentation.

Throughout the code, the 'min_interval' is used to show some logging/stats updates. This is the reason why I decided to keep this name since its purpose is to show a warning the the spin limit has been reached.

I have added some documentation for this variable as well.

@DBa2016 min_interval is just about the warning message, doesn't pause the bot etc.

kolinkorr839 · 2016-09-20T23:04:46Z

Here's 2 tests that I did.

If bypass_daily_limit is not changed (default to false), this is the output when daily_spin_limit is reached (it stops the script just like it does right now)

[2016-09-20 15:13:15] [MoveToFort] Moving towards pokestop Sister Cities Bench 1 - 0.04km (attraction of lure 0.04km)
[2016-09-20 15:13:19] [  SpinFort] Spun pokestop Sister Cities Bench 1. Experience awarded: 50. Items awarded: 3x Pokeball
[2016-09-20 15:13:24] [MoveToFort] Moving towards pokestop San Francisco Ferry Terminal Landmark  - 0.05km (attraction of lure 0.05km)
[2016-09-20 15:13:27] [  SpinFort] Spun pokestop San Francisco Ferry Terminal Landmark . Experience awarded: 50. Items awarded: 1x Potion, 2x Pokeball
[2016-09-20 15:13:31] [MoveToFort] Moving towards pokestop In Memory of Herb Caen - 0.08km
[2016-09-20 15:13:37] [MoveToFort] Moving towards pokestop In Memory of Herb Caen - 0.06km
[2016-09-20 15:13:42] [MoveToFort] Moving towards pokestop In Memory of Herb Caen - 0.05km (attraction of lure 0.05km)
[2016-09-20 15:13:47] [  SpinFort] Spun pokestop In Memory of Herb Caen. Experience awarded: 50. Items awarded: 2x Pokeball, 1x Greatball
[2016-09-20 15:13:50] [MoveToFort] Moving towards pokestop Pier 1 1/2, 3 & 5 Historic Site - 0.08km
[2016-09-20 15:13:52] [  SpinFort] WARNING! You have reached your daily spin limit

If bypass_daily_limit is set to true, this is the output when daily_spin_limit is reached which allows the bot to continue doing its business. But it gives a warning from time to time that the daily_spin_limit has been reached

[2016-09-20 15:16:37] [MoveToFort] Moving towards pokestop The River Lines - 0.04km (attraction of lure 0.04km)
[2016-09-20 15:16:39] [  SpinFort] Spun pokestop The River Lines. Experience awarded: 50. Items awarded: 2x Pokeball, 1x Hyper Potion
[2016-09-20 15:16:43] [MoveToFort] Moving towards pokestop Embarcadero Freeway To Nowhere Comes Down - 0.09km
[2016-09-20 15:16:44] [  SpinFort] WARNING! You have reached your daily spin limit
[2016-09-20 15:16:48] [MoveToFort] Moving towards pokestop Embarcadero Freeway To Nowhere Comes Down - 0.07km
[2016-09-20 15:16:54] [MoveToFort] Moving towards pokestop Embarcadero Freeway To Nowhere Comes Down - 0.05km
[2016-09-20 15:16:59] [  SpinFort] Spun pokestop Embarcadero Freeway To Nowhere Comes Down. Experience awarded: 50. Items awarded: 3x Pokeball
....
....
[2016-09-20 15:18:32] [MoveToFort] Moving towards pokestop Pier 7 - 0.04km
[2016-09-20 15:18:35] [  SpinFort] Spun pokestop Pier 7. Experience awarded: 100. Items awarded: 1x Razz Berry, 1x Potion, 3x Pokeball, 1x Revive
[2016-09-20 15:18:39] [MoveToFort] Moving towards pokestop Dangerous Sailor Lives - 0.07km
[2016-09-20 15:18:45] [  SpinFort] WARNING! You have reached your daily spin limit
[2016-09-20 15:18:45] [MoveToFort] Moving towards pokestop Dangerous Sailor Lives - 0.05km

Gobberwart · 2016-09-21T01:11:23Z

You'll need to rebase this, it's showing a bunch of commits that aren't related to this PR

Gobberwart · 2016-09-21T01:13:00Z

pokemongo_bot/cell_workers/spin_fort.py

+           if datetime.now() >= self.next_update:
+               self.emit_event('spin_limit', formatted='WARNING! You have reached your daily spin limit')
+               self._compute_next_update()
+


Still needs to stop and return from this method. No point running the rest of the work code if daily_spin_limit is reached.

That is true.. I will make the change.

Gobberwart · 2016-09-21T05:37:51Z

docs/configuration_files.md

@@ -207,6 +207,9 @@ The behaviors of the bot are configured via the `tasks` key in the `config.json`
  * `enable`: Disable or enable this task.
  * `spin_wait_min`: Default 3 | Minimum wait time after fort spin
  * `spin_wait_max`: Default 5 | Maximum wait time after fort spin
+  * `daily_spin_limit`: Default 2000 | Daily spin limit
+  * `min_interval`: Default 120 | When daily spin limit is reached, how often should the warning message be shown
+  * `bypass_daily_limit`: Default `False` | Disable the spin daily limit protection


Not sure about "bypass_daily_limit" as a name, since that's not really what it does. If this is true, it lets the bot continue to catch/evolve/transfer etc without spinning forts. The limit is still observed, just the behavior when limit is reached is different.

Maybe: 'exit_on_limit_reached': true/false (default False) and reverse the way the condition works.

Thanks. 'exit_on_limit_reached' sounds better. I will make the change.

Gobberwart · 2016-09-26T22:42:33Z

The only outstanding issue I can see is from @DBa2016 Plus - sometimes, you want actually to continue running and apturing pokemons and sniping even with a reached daily limit.

Maybe this could have a "warning only" mode AS WELL, which generates log messages, but still functions anyway.

Gobberwart · 2016-09-26T22:53:43Z

OK so dba2016's concern has been addressed. Not sure if we REALLY need that third option then (bypass_daily_limit). Just exit or continue, as it is now.

…exiting

…se, then the code will exit. When daily_spin_limit is reached and bypass_daily_limit is set to true, then the bot will continue its business. It will send a message every 2 minutes (default but can be changed) that the daily spin limit has been reached.

Gobberwart · 2016-09-26T23:53:39Z

OK, looks good. Merging.

Gobberwart reviewed Sep 20, 2016

View reviewed changes

Gobberwart suggested changes Sep 20, 2016

View reviewed changes

DBa2016 requested changes Sep 20, 2016

View reviewed changes

DBa2016 added the Waiting on Changes label Sep 20, 2016

Gobberwart reviewed Sep 21, 2016

View reviewed changes

kolinkorr839 force-pushed the continue_spin_fort branch from 255a3de to 980fb5a Compare September 21, 2016 03:05

Gobberwart reviewed Sep 21, 2016

View reviewed changes

kolinkorr839 force-pushed the continue_spin_fort branch from a5ab825 to 7c1e1f8 Compare September 21, 2016 21:53

Gobberwart approved these changes Sep 22, 2016

View reviewed changes

Gobberwart mentioned this pull request Sep 22, 2016

Reaching daily spin limit is causing multiple teleport #5462

Closed

kolinkorr839 added 4 commits September 26, 2016 16:01

When daily spin limit is reached, let it continue working instead of …

26a4e7c

…exiting

no need for this method to continue if the daily_spin_limit is reached

abde615

rename bypass_daily_limit to exit_on_limit_reached

cebe496

kolinkorr839 force-pushed the continue_spin_fort branch from 703f016 to cebe496 Compare September 26, 2016 23:20

Gobberwart merged commit ec893ec into PokemonGoF:dev Sep 26, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When daily spin limit is reached, let it continue working instead of … #5550

When daily spin limit is reached, let it continue working instead of … #5550

kolinkorr839 commented Sep 19, 2016

mention-bot commented Sep 19, 2016

solderzzc commented Sep 19, 2016

Gobberwart Sep 20, 2016

DBa2016 Sep 20, 2016

kolinkorr839 Sep 20, 2016

Gobberwart left a comment

DBa2016 left a comment

DBa2016 Sep 20, 2016

DBa2016 Sep 20, 2016

kolinkorr839 Sep 20, 2016

Gobberwart Sep 22, 2016

kolinkorr839 commented Sep 20, 2016

Gobberwart commented Sep 21, 2016

Gobberwart Sep 21, 2016

kolinkorr839 Sep 21, 2016

Gobberwart Sep 21, 2016

kolinkorr839 Sep 21, 2016

Gobberwart commented Sep 26, 2016

Gobberwart commented Sep 26, 2016

Gobberwart commented Sep 26, 2016

When daily spin limit is reached, let it continue working instead of … #5550

When daily spin limit is reached, let it continue working instead of … #5550

Conversation

kolinkorr839 commented Sep 19, 2016

Short Description:

mention-bot commented Sep 19, 2016

solderzzc commented Sep 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gobberwart left a comment

Choose a reason for hiding this comment

DBa2016 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kolinkorr839 commented Sep 20, 2016

Gobberwart commented Sep 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gobberwart commented Sep 26, 2016

Gobberwart commented Sep 26, 2016

Gobberwart commented Sep 26, 2016