Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeDecodeError catch #5312

Merged
merged 2 commits into from
Sep 9, 2016
Merged

UnicodeDecodeError catch #5312

merged 2 commits into from
Sep 9, 2016

Conversation

Gobberwart
Copy link
Contributor

Short Description:

If non-unicode string passed to parse_unicode_str, bot crashes. Previously was catching only UnicodeEncodeError, added UnicodeDecodeError as well.

Fixes/Resolves/Closes (please use correct syntax):

@mention-bot
Copy link

@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vieira, @douglascamata and @TheSavior to be potential reviewers

@solderzzc
Copy link
Contributor

solderzzc commented Sep 9, 2016

👍 uh, UTF8 again

Approved with PullApprove

@Gobberwart Gobberwart merged commit 732463c into PokemonGoF:dev Sep 9, 2016
@Gobberwart Gobberwart deleted the dev_unicodeerror branch September 9, 2016 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants