Telegram Connection pool is full (and other tweaks)

[Gobberwart]

Short Description:

Increase connection pool size to eliminate connection pool is full errors.
Removed unnecessary code from get_player_stats
Minor text tweaks (replace "spin up" with "start")

Fixes/Resolves/Closes (please use correct syntax):

• Telegram- sending 2 notifications per event and repetitive line in logger #4977

[mention-bot]

@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DBa2016, @askovpen and @solderzzc to be potential reviewers

[solderzzc]

Yes, the 'Connection pool is full' message is the only thing I can see on the console.

[Gobberwart]

Hmmm CI failed with error

======================================================================
FAIL: test_api_call_throttle_should_fail (tests.api_wrapper_test.TestApiWrapper)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/timeout_decorator/timeout_decorator.py", line 69, in new_function
    return function(*args, **kwargs)
  File "/home/travis/build/PokemonGoF/PokemonGo-Bot/tests/api_wrapper_test.py", line 116, in test_api_call_throttle_should_fail
    request.call()
AssertionError: TimeoutError not raised

You think that's related? Shouldn't be but not sure... Any thoughts?

[Gobberwart]

    @timeout(1) # expects a timeout
    def test_api_call_throttle_should_fail(self):
        request = FakeApi().create_request()
        request.is_response_valid = MagicMock(return_value=True)
        request.requests_per_seconds = 5

        with self.assertRaises(TimeoutError):
            for i in range(request.requests_pe

[Gobberwart]

Never mind, build passed now without me changing anything. Should be ready to merge if someone wants to approve it.

[sohje]

What is this for?

[Gobberwart]

Nothing at all. Was part of something I was testing, now unneccessary. Removing before merging.

[Gobberwart]

Removed in latest commit. Good catch, thanks.

[Gobberwart]

@sohje Lots of comments on things that are not relevant to this PR. Yes, Telegram_handler.py needs a cleanup but not here.

[sohje]

@Gobberwart You already done some cleanup with this PR. That's why i commented. This PR about fix pool size, half cleanup also added?

request.CON_POOL_SIZE = 16

[solderzzc]

👍

[solderzzc]

Let's remove the mass log with no much meaning on console.

[Gobberwart]

@sohje I only updated things that irritated me. In fact, this PR was originally going to be just about removing code from get_player_stats but I figured I'd look at connection pool while I was at it and that's probably more important.

So yeah, not really much of a cleanup going on. I'll look into the other stuff later.

[sohje]

@Gobberwart Okay, good. I dont mean any harm 👍

[Gobberwart]

@sohje All good mate, just don't want the PR bogged down in unrelated minutiae.

[Gobberwart]

OK to merge now then? Please approve.

[solderzzc]

👍 Don't pretend you can not merge :)

[Gobberwart]

LOL I know I can, I just prefer to let someone else check my work first :)