Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snipping improvements (PR #5247) #5303

Merged
merged 2 commits into from
Sep 8, 2016
Merged

Snipping improvements (PR #5247) #5303

merged 2 commits into from
Sep 8, 2016

Conversation

YvesHenri
Copy link
Contributor

@YvesHenri YvesHenri commented Sep 8, 2016

Non-social information (url) are now validated against expiration (exists). This also allows other crowd-based applications/sites to work this bot (https://github.com/YvesHenri/PogoLocationFeeder).
Teleporting to target log is now yellow.

…ists). This also allows other crowd-based applications/sites to work this bot (https://github.com/YvesHenri/PokemonGo-Bot).

Teleporting to target log is now yellow.
@mention-bot
Copy link

@YvesHenri, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mhdasding, @chrisle and @Napator to be potential reviewers

@solderzzc
Copy link
Contributor

solderzzc commented Sep 8, 2016

👍 Thanks for the PR, let's merge.

Approved with PullApprove

@solderzzc solderzzc merged commit e92cb8b into PokemonGoF:dev Sep 8, 2016
@YvesHenri YvesHenri deleted the dev branch September 8, 2016 22:42
@novadev94
Copy link
Contributor

novadev94 commented Sep 10, 2016

Hi @YvesHenri, I'm seeing update_map_location removed (https://github.com/PokemonGoF/PokemonGo-Bot/pull/5303/files#diff-13dfb7470ca1360a74ad4eabf7bb11a2L230).

Do we have alternate ways to update the location on PokemonGo-Map (based on the bot position)?

Also related to this #5313

@YvesHenri
Copy link
Contributor Author

MoveToMapPokemon was first made exclusively to work with PokemonGo-Map. It is going to be deprecated and support multiple urls/sources. Since move_map_location is PokemonGo-Map related (and useless, unless you prove me wrong), it was removed.

@novadev94
Copy link
Contributor

@YvesHenri Oh no worry. I made a PR and only saw your PR after that. So I thought maybe I had misunderstood so I wanted to clarify/confirm it first before making any unnecessary changes that may conflict with your ideas. Well done 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants