Prevent duplicate "skip ignored pokemon" alerts #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 86f573434b214b2c6dcb89d24c34aaccb911479f.
This reverts commit 361782f.
|
@Gobberwart, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pokepal, @alexyaoyang and @Likael to be potential reviewers |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
Persist ignored/skipped pokemon so that alerts are not continually generated.
Important note: An encountered pokemon does not have a useful unique id (at least not that I can see) so I have used pokemon_id, cp_exact and ivcp as comparison values when deciding if an alert has already been generated. That should be sufficient but happy to expand if necessary.
Fixes/Resolves/Closes (please use correct syntax):