IncubateEggs update #5125
Merged
IncubateEggs update #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added return of WorkerResult that depends on egg hatching * Fixed eggs and incubators list not being updates after last one used * Now using class Pokemon from inventory
Added colored logging to eggs_hatched_log
|
CI failed because the |
|
|
||
|
|
||
| class IncubateEggs(BaseTask): | ||
| class IncubateEggs(Datastore, BaseTask): |
There was a problem hiding this comment.
Yeah, I was waiting your PR to be merge, already had changes made. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
IncubateEggs task now return WorkerResult depending on egg hatching.
Now uses class Pokemon from
inventory.pyto display Pokemon stats and data.Created table
eggs_hatched_login db to log eggs hatched.Print ncp of the Pokemon.
Fixes/Resolves/Closes (please use correct syntax):