Check awarded badges updates try 2 #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
have tested with a brand new account, self.api.equip_badge(badge_type=badge) does not work but i've commented it out. will need to know if they send it with another request maybe. it displays |
|
@duttonw Just change init a bit ago |
…o check_awarded_badges_updates_3
|
@mjmadsen Merged, no changes to my section. |
|
Let's merge in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
update to store player_data and check_awarded_badges on success
emit events when awarded badge is returned and begin code changes for equip badge
add color to badge log
Fixes
begin fixing #4522
#4721 fixes