-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay task logs #4724
Delay task logs #4724
Conversation
@Gzerox, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata, @mjmadsen and @mhdasding to be potential reviewers |
Ops, i forgot to write tests case. 😭 Please don't close ! |
@@ -169,7 +169,8 @@ | |||
"enabled": true, | |||
"lure_attraction": true, | |||
"lure_max_distance": 2000, | |||
"walker": "StepWalker" | |||
"walker": "StepWalker", | |||
"log_delay": 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, log_delay the wording lead me misunderstood. I was thinking the log will delay to show, that's not what you mean in code.
Any better wording suggestion since I'm not English natively speaking guy :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log_interval maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or terminal_update_delay
Could you please update configuration_files.md as well? |
|
@@ -1 +1 @@ | |||
Subproject commit 6ba5609c6151507b5b832a74e471b6b7b1a182c9 | |||
Subproject commit 607397a13f344c0fdc44bd9961332c1efe205de9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this version of web working with current branch?
@Gzerox A small bug when recycling items:
|
I'm traveling right now, bit the follow addition should fix the problem: File: services/item_recycle_worker.py method init:
Thanks! |
Added that change in a PR @Gzerox Thanks! |
Short Description:
I just wanted to find a way to put a delay between each "moving_to_fort" log.
The implementation is bit more generic to allow easily setup a delay for other worker too.
I know that this is not a needed stuff, and probably useless
But, hey ! I'm python beginner, just having fun :P
Fixes/Resolves/Closes: