Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random delay for animation if new to dex #4714

Merged
merged 8 commits into from
Aug 25, 2016
Merged

Add random delay for animation if new to dex #4714

merged 8 commits into from
Aug 25, 2016

Conversation

mjmadsen
Copy link
Contributor

  • Added a random delay if the pokemon we caught is new to our pokedex

Closes #4700

@mention-bot
Copy link

@mjmadsen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Quantra, @RedViper9 and @rawgni to be potential reviewers

@rawgni
Copy link
Contributor

rawgni commented Aug 25, 2016

lgtm

@mjmadsen
Copy link
Contributor Author

@rawgni you've had a chance to test?

rawgni
rawgni reviewed Aug 25, 2016
View reviewed changes
pokemongo_bot/cell_workers/pokemon_catch_worker.py
@@ -545,6 +549,10 @@ def _do_catch(self, pokemon, encounter_id, catch_rate_by_ball, is_vip=False):
}, outfile)
outfile.write('\n')

# if it is a new pokemon to our dex, simulate app animation delay
if exp_gain >= 500:
sleep (randrange(newtodex_wait_min, newtodex_wait_max))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjmadsen the variable here should be catchsim_newtodex_wait_min and catchsim_newtodex_wait_max

@mjmadsen
Copy link
Contributor Author

@rawgni Fixed. 👍

@solderzzc
Copy link
Contributor

Thanks, merging.

@solderzzc solderzzc merged commit e2e13cf into PokemonGoF:dev Aug 25, 2016
alexyaoyang pushed a commit to alexyaoyang/PokemonGo-Bot that referenced this pull request Aug 25, 2016
Hotfix for PokemonGoF#4714
aee97e2
@alexyaoyang alexyaoyang mentioned this pull request Aug 25, 2016
Merged
alexyaoyang added a commit that referenced this pull request Aug 25, 2016
@alexyaoyang
Hotfix for #4714 (#4728)
f642926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help to Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjmadsen @mention-bot @rawgni @solderzzc