fix(map-chat): disable dummy info window #4707
Conversation
|
@geminiyellow, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BreezeRo and @solderzzc to be potential reviewers |
geminiyellow
force-pushed
the
fix-disable-dummy-info-window
branch
from
341564b to
cc08aac
Compare
| @@ -320,9 +320,8 @@ function displayMessageOnMap(msg, olat, olong, sessid, icostr, expir, pokenick) | |||
| } | |||
| }); | |||
|
|
|||
| if (msg.text) { | |||
| if (msg.text !== 'undefined') { | |||
There was a problem hiding this comment.
display the location is not that bad...
There was a problem hiding this comment.
@solderzzc yep, display the location is not bad, but the infoWindow is meaningless, i dont think human can read it. you can try it by yourself. btw, the same info is output in console.debug, too.
and, if you want a infoWindow, i think there should have a filter.just pop up what you want.
|
I've understood what you meant, thanks a lot. |
|
I'd like to have the dummy info back, till we find a better GUI. |
Short Description:
msg.text = html_sanitize(msg.text);returnundefinedas'undefined'.Fixes:
disable
just appearedinfo window