Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SleepSchedule from workers to main bot instance #4635

Merged
merged 7 commits into from
Aug 25, 2016
Merged

Move SleepSchedule from workers to main bot instance #4635

merged 7 commits into from
Aug 25, 2016

Conversation

cmezh
Copy link
Contributor

@cmezh cmezh commented Aug 23, 2016

...and some whitespace cleaning.
This prevents logging in to account before bot goes sleep if bot is launched at sleep time.
And also in my opinion SleepSchedule is not a regular task and it's better to put it into bot directly.

@mention-bot
Copy link

@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @buluba89, @supercourgette and @MMnsgo to be potential reviewers

@solderzzc
Copy link
Contributor

CI build failed :(

@cmezh
Copy link
Contributor Author

cmezh commented Aug 24, 2016

@solderzzc Fixed and tested :)

@solderzzc
Copy link
Contributor

Can we add console log to tell user the format of conf changed when they have the schedule sleep task configured ? Or, another dev broken help wave will come.

@cmezh
Copy link
Contributor Author

cmezh commented Aug 24, 2016

@solderzzc Done.

@solderzzc
Copy link
Contributor

@cmezh Thanks a lot.

@solderzzc solderzzc merged commit 208f601 into PokemonGoF:dev Aug 25, 2016
@cmezh cmezh deleted the sleepsched branch August 25, 2016 09:03
@kenkclam
Copy link

How should the config looks like now?

In the example, SleepSchedule is still under tasks?

https://github.com/PokemonGoF/PokemonGo-Bot/blob/ae314b666a1eb71de8872289ef3a298af09e4637/configs/config.json.example

@cmezh
Copy link
Contributor Author

cmezh commented Aug 26, 2016

@kenkclam It looks like my examples changes were overwritten by soneones PR.
See example here: https://github.com/cmezh/PokemonGo-Bot/blob/03361efd5305bd78be0aebaafd463d5a11fd7628/configs/config.json.example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants