-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SleepSchedule from workers to main bot instance #4635
Conversation
@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @buluba89, @supercourgette and @MMnsgo to be potential reviewers |
CI build failed :( |
@solderzzc Fixed and tested :) |
Can we add console log to tell user the format of conf changed when they have the schedule sleep task configured ? Or, another dev broken help wave will come. |
@solderzzc Done. |
@cmezh Thanks a lot. |
How should the config looks like now? In the example, SleepSchedule is still under tasks? |
@kenkclam It looks like my examples changes were overwritten by soneones PR. |
...and some whitespace cleaning.
This prevents logging in to account before bot goes sleep if bot is launched at sleep time.
And also in my opinion SleepSchedule is not a regular task and it's better to put it into bot directly.