Add option to separate usage of incubator unbreakable from breakable (2)

[supercourgette]

Short Description:

• The 2, 5 and 10km eggs can be dispatched between either the infinite or the breakables incubators.

I wasn't able to test this option in real-game, since well... My bot is sleeping. From the tests I ran, the option should behave as excepted.

Fixes/Resolves/Closes (please use correct syntax):

• Closes Configure which incubators use 2, 5 or 10km #3503
• Closes [Feature Request] Differentiate Between Unlimited and "Purchased" Incubator use. #3552

Not sure why it failed before (cf #4556)

[mention-bot]

@supercourgette, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mjmadsen, @DeXtroTip and @TheSavior to be potential reviewers

[mjmadsen]

CI passed this time. Woot.

[alexyaoyang]

This is a great feature! Just a quick question. Will the default values on line 27 and 28 of incubate_eggs.py break old configs which doesn't have the new fields?

[mjmadsen]

@alexyaoyang #4564 is a fix for that.

[supercourgette]

It would have work without the fix though :)

On Aug 23, 2016 1:39 AM, "Matt J Madsen" [email protected] wrote:

@alexyaoyang #4564 is a fix for that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[mjmadsen]

@supercourgette From the looks of it, if they did not update their config, both would be empty when we try them.

[supercourgette]

Oh, yes I see, It would not have been broken thought but I see a case I
didn't account for. If an user put an empty array then my code just ignore
the option (which now I think about it is not the indented behavior). I
don't have my computer right now, I'll check this case tomorrow. In the
mean time it is a bit broken in case of empty array. I'm sorry for the
inconvenience :(

On Aug 23, 2016 1:45 AM, "Matt J Madsen" [email protected] wrote:

@supercourgette From the looks of it, if they did not update their
config, both would be empty when we try them.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[alexyaoyang]

Don't worry about it, I'll submit a PR :)

[supercourgette]

Thanks :). And sorry for the mistake :)

On Aug 23, 2016 1:53 AM, "Alex Yao" [email protected] wrote:

Don't worry about it, I'll submit a PR :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4564 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD31cRPg1-3IVg-bT6zmamNkUXn5VME7ks5qidP9gaJpZM4JqANG
.

[alexyaoyang]

No problem! Thank @mjmadsen too, he pushed & merged the fix already :)

[mjmadsen]

I am getting drained. Either I'll fall asleep soon or have more coffee and keep rocking PRs.

[alexyaoyang]

@mjmadsen Very productive stretch! Great job!

[supercourgette]

Developers sleep? :P

On Aug 23, 2016 2:03 AM, "Matt J Madsen" [email protected] wrote:

I am getting drained. Either I'll fall asleep soon or have more coffee and
keep rocking PRs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4564 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD31cQf6qGfTYZMrPC0CqSuhc3gE0n1vks5qidZigaJpZM4JqANG
.

[k4n30]

@supercourgette what about the other config files being update? Happy the doco got done though :)