Fix UnicodeEncodeError causing location not found #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are special characters in initial location, e.g. "ç" a UnicodeEncodeError is raised and caught causing valid initial locations being reported as not parsable.
|
@vieira did you test this? |
|
Yes, I did. You can use e.g. "Praça do Comércio, Lisbon" as initial location to reproduce the problem and test the fix. |
|
Tested and confirmed as working. |
hoanghuynh
pushed a commit
to hoanghuynh/PokemonGo-Bot
that referenced
this pull request
Sep 28, 2016
…okemonGoF#1054) * Like PokemonGoF#1043, but with migration as well. Stupid, stupid peewee migration...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description:
When there are special characters in initial location, e.g. "ç" a UnicodeEncodeError is raised and caught causing valid initial locations being reported as not parsable.
Fixes: