Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - MoveToMapPokemon stop catching when VIP #4227

Closed
ebbrey opened this issue Aug 18, 2016 · 12 comments
Closed

Feature Request - MoveToMapPokemon stop catching when VIP #4227

ebbrey opened this issue Aug 18, 2016 · 12 comments

Comments

@ebbrey
Copy link

ebbrey commented Aug 18, 2016

Short Description:

When not sniping and just walking towards a vip pokemon. It would be great if the bot could have a coupple settings like "don't-spin-pokestops". and "only-catch-VIP-until-encountered-VIP".
Then resume after.

Sometimes when you set the bot to walk slow and its encountering alot of pokemons, and even missing throws on purpose etc.., the timer runs out and you don't reach the VIP.

@jaimerson
Copy link

Also, this would make the more more human-like. I mean, who would ignore a Charizard and catch a bunch of Pidgeys?

@k4n30
Copy link
Contributor

k4n30 commented Aug 19, 2016

Who sets move to map to choose Pidgey's though? If you config it that way, u deserve to miss Charizard

@jaimerson
Copy link

@k4n30 sure, but maybe this feature should be always prioritise VIPs over other Pokémon/pokestops when they're available

@k4n30
Copy link
Contributor

k4n30 commented Aug 19, 2016

Or prioritise based on snipe value as long as conditions are met (i.e. it goes for 1000s -> 900 -> 800 etc if it can get there in time) and then others (pokemon with no value like pidgey)

@mvrska
Copy link
Contributor

mvrska commented Aug 19, 2016

and when I proposed this 3 weeks ago noone wanted it -.-

This would require some global variable (eg. should_continue_catching) to be set and the catch task only would work based on this variable.
Would you guys like to have it for VIPs only or for example using the high_prio_threshold there is for sniping?

@ebbrey
Copy link
Author

ebbrey commented Aug 19, 2016

High_prio_threshold is a good idea to use..

@k4n30
Copy link
Contributor

k4n30 commented Aug 19, 2016

both? if you're going to add one, why not the other?

@mvrska
Copy link
Contributor

mvrska commented Aug 19, 2016

I have to see whether I can even do that :P other than that there is no real reason why not both, but probably I would maybe combine this with the sniping feature - if snipe is false, use it's settings for determining to ignore stuff

@masterpowers
Copy link

thumbs up

@k4n30
Copy link
Contributor

k4n30 commented Aug 22, 2016

@masterpowers actually use the thumbs up option on the OP or it wont be counted

sohje added a commit to sohje/PokemonGo-Bot that referenced this issue Aug 25, 2016
solderzzc added a commit that referenced this issue Aug 25, 2016
Resolve issue #4227 - MoveToMapPokemon stop catching when VIP
@sohje
Copy link
Contributor

sohje commented Aug 25, 2016

Merged, check it out guys.

@ebbrey
Copy link
Author

ebbrey commented Aug 25, 2016

Really great! Thanks alot for filling the request :)

@k4n30 k4n30 closed this as completed Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants