follow_path: loitering option

[ukos-git]

repost of the lost issue PokemonGoF/PokemonGo-Bot#5416

brief summary:
There is a misunderstanding of the use of the loitering functionality.
@alexyaoyang, myself and the original author of the loitering option wanted to use it to let the bot handle other running tasks. current master has this functionality. It is also explained in the docs.

In dev the loitering was changed to really do nothing at all besides catching pokemon etc. so the running task was held further active.

The newly changed behaviour should also be the case if no running task at all is added after the loitering. Therfore I would like to revert the old loitering behaviour if @anakin5 agrees who's to blame.

Any thoughts maybe from @janpascal

[alexyaoyang]

Thanks for bring this back @ukos-git. I've yet to look through the issues that @anakin5 was trying to solve when he changed the loiter feature, seems like it might not be possible now.

I agree that the loiter feature should allow bot to walk if users chooses, but let's not blame @anakin5 for thinking that loiter doesn't move, since the word loiter does have both meanings of waiting still and walking around.

I suggest we add the old loiter back, and at the same time improve on our docs to tell users clearly that the bot will behave differently based on what task arrangement they have.

[janpascal]

Agreed. Maybe the term loitering is to blame, I'm not native in English so it may have connotations I didn't expect.

By the way, in master loitering with a polylinewalker doesn't work properly, I'm trying to find out what's wrong.

[ukos-git]

I was just using the term blame because of the git blame command which is btw one nice feature. No offense.
For me it was the first time using the bot so I really think, that improving the docs at that point would help.
I am also not native english and had to look the term up as I never heard of it. Maybe don't use "loiter" at all. "wander" would be a more clear word to me.

[janpascal]

+1 for changing the name to 'wander'.

[julienlavergne]

It is ok for me as well. We just have to return Success instead of running.