Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sample_consensus] Circle3D: Changed segmentation collinear check precision from float to double. #6175

Merged

Conversation

ralphieraccoon
Copy link
Contributor

Fixes #6172.

@mvieth mvieth added module: sample_consensus changelog: fix Meta-information for changelog generation labels Nov 21, 2024
@mvieth
Copy link
Member

mvieth commented Nov 21, 2024

@ralphieraccoon Thanks for the pull request! However, I would prefer to only change this for the circle3D model at the moment, because only that model uses double precision to compute the model coefficients, while the other four models use single precision (float). So it makes sense that the other models use Eigen::NumTraits<float>::dummy_precision (), not Eigen::NumTraits<double>::dummy_precision ().

@ralphieraccoon
Copy link
Contributor Author

ralphieraccoon commented Nov 21, 2024

OK, I think it might be a good idea to get double precision at least for ellipse3D as well, but that can be done in another PR.

Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

OK, I think it might be a good idea to get double precision at least for ellipse3D as well, but that can be done in another PR.

Do you mean converting the whole computeModelCoefficients of elliipse3D to double precision? Yes, I see how that could be useful for very small point clouds.

@mvieth mvieth merged commit 75ef8c5 into PointCloudLibrary:master Nov 22, 2024
13 checks passed
@ralphieraccoon ralphieraccoon deleted the double_precision_segmentation branch November 22, 2024 11:20
@mvieth mvieth changed the title [sample_consensus] Changed segmentation collinear check precision from float to double. [sample_consensus] Circle3D: Changed segmentation collinear check precision from float to double. Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Meta-information for changelog generation module: sample_consensus
Projects
None yet
2 participants