Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get macos CIs running again #4579

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

mvieth
Copy link
Member

@mvieth mvieth commented Jan 20, 2021

It seems like OpenNI has not been installed for longer than the problems with depends_on java exist (and just fixing these dependency problems does not result in OpenNI being installed again). I suggest we open an issue to investigate those problems.

So that the first command succeeds even if the second one fails
@mvieth mvieth changed the title macos CIs: point brew to own repository where depends_on java errors … Get macos CIs running again Jan 20, 2021
@mvieth mvieth marked this pull request as ready for review January 20, 2021 15:45
@mvieth mvieth requested review from koide3 and larshg January 20, 2021 15:45
@larshg
Copy link
Contributor

larshg commented Jan 20, 2021

Since https://github.com/brewsci/homebrew-science is legacy and doesnt get any new PRs accepted, we might as well just remove it?
I'm not sure if we can get in another way, though?

@mvieth
Copy link
Member Author

mvieth commented Jan 20, 2021

Since https://github.com/brewsci/homebrew-science is legacy and doesnt get any new PRs accepted, we might as well just remove it?

Maybe they are going to make an exception for that specific PR, since right now apparently no project can be installed from that repository.

I'm not sure if we can get in another way, though?

No idea. My intention with this PR is to get the macos CIs running again as soon as possible. Then we can work on getting OpenNI installed again in a next step.

@larshg
Copy link
Contributor

larshg commented Jan 20, 2021

Yeah, lets keep it. If they manage to get it working, openni would be installed again. But until its fixed, the core libraries are still getting installed 😄

@mvieth mvieth merged commit b59658f into PointCloudLibrary:master Jan 22, 2021
@mvieth mvieth deleted the macos-brew-fix branch January 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants