Skip to content

Commit

Permalink
Merge pull request #28 from Pogchamp-company/feature/-/create-communi…
Browse files Browse the repository at this point in the history
…ty-docs

Create community docs
  • Loading branch information
RustyGuard authored Sep 30, 2023
2 parents 81f763c + 77f2761 commit a90b30f
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 5 deletions.
27 changes: 27 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
<!-- Describe your changes in detail -->

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)
-->

This pull request is:

- [ ] A documentation / typographical / small typing error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- please include the issue number, and create an issue if none exists, which
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests. one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ To the top of your migrations/env.py file.
* [Deletion of enums values](#deletion-of-enums-values)
* [Renaming of enum values](#rename-enum-value)

### Creation of enum
### Creation of enum<a id="creation-of-enum"></a>

#### When table is created

Expand Down Expand Up @@ -109,7 +109,7 @@ def downgrade():
# ### end Alembic commands ###
```

### Deletion of unreferenced enum
### Deletion of unreferenced enum<a id="deletion-of-unreferenced-enum"></a>
If enum is defined in postgres schema, but its mentions removed from code - It will be automatically removed
```python
class ExampleTable(BaseModel):
Expand All @@ -132,7 +132,7 @@ def downgrade():
# ### end Alembic commands ###
```

### Creation of new enum values
### Creation of new enum values<a id="creation-of-new-enum-values"></a>

If new enum value is defined sync_enum_values function call will be added to migration to account for it

Expand Down Expand Up @@ -161,7 +161,7 @@ def downgrade():
# ### end Alembic commands ###
```

### Deletion of enums values
### Deletion of enums values<a id="deletion-of-enums-values"></a>

If enum value is removed it also will be detected

Expand Down Expand Up @@ -189,7 +189,7 @@ def downgrade():
# ### end Alembic commands ###
```

### Rename enum value
### Rename enum value<a id="rename-enum-value"></a>
In this case you must manually edit migration

```python
Expand Down

0 comments on commit a90b30f

Please sign in to comment.