Transcript Updates? #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the changes we've been discussing in issue Podcastindex-org#16 . What do you think?
tomrossi7
commented
Oct 12, 2020
|
|
||
| All attributes are required. | ||
| The language of the transcript can be overwritten by providing the optional language attribute. All other attributes are required. |
There was a problem hiding this comment.
What about making the language optional? In most cases we have 3 transcript types available for each episode in the RSS feed. This would reduce the amount of code required as long as we are comfortable defaulting to the same language as the podcast.
There was a problem hiding this comment.
That's fair. Let's do that. I may clarify your statement here as we go refine the wording of things.
There was a problem hiding this comment.
Sure thing! I'm happy to help, but am more comfortable with code than english 🤣
| Item | ||
|
|
||
| (optional | single) | ||
| (optional | multiple) |
There was a problem hiding this comment.
This should be multiple if the transcripts is available in different formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes we've been discussing in issue #16 . What do you think?