Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): fix async resource attribute access issue #667

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kschelonka
Copy link
Contributor

@kschelonka kschelonka commented Jul 22, 2024

Seeing "Accessing resource attributes before async attributes settled" errors in v3 proxy after the package update. Implementing fixed referenced in the issue below.

open-telemetry/opentelemetry-js#4638

POCKET-10371

@kschelonka kschelonka requested a review from a team as a code owner July 22, 2024 22:06
@kschelonka kschelonka requested review from Gio2018 and removed request for a team July 22, 2024 22:06
@kschelonka kschelonka enabled auto-merge July 22, 2024 22:07
Copy link

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kschelonka kschelonka added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 820a2a9 Jul 22, 2024
92 checks passed
@kschelonka kschelonka deleted the fix/otel-async branch July 22, 2024 22:40
Copy link

🎉 This PR is included in version @pocket-tools/tracing-v1.3.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants