Revert(model): revert dataset counts of habs and taxs #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3320 +/- ##
========================================
Coverage 83.93% 83.93%
========================================
Files 122 122
Lines 9715 9711 -4
========================================
- Hits 8154 8151 -3
+ Misses 1561 1560 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camillemonchicourt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert feat added in #3293
Celle-ci posait en effet des soucis de performances car on comptait le nombre d'occurrences de taxons et d'habitat de chaque JDD à chaque fois qu'on appelait la route /datasets, donc partout où on affiche ou liste des JDD.
Il faut que la propriété qui compte les occurrences soit optionnelles et calculée que si explicitement demandée, comme c'est déjà le cas avec la propriété
synthese_records_countutilisée uniquement quand on liste les JDD d'un CA dans le module métadonnées (https://github.com/PnX-SI/GeoNature/blob/master/frontend/src/app/metadataModule/metadata-dataset.component.html#L75)