-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix'ify docs website, and check for broken links in CI #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs look good, I think you fixed all the remaining broken links too?
Also, I was curious, can we have a search feature somehow?
actually could you also fix the hyperlink here please - I accidentally made it |
Yup.
Not right now, but eventually1 I'd like to integrate something like https://stork-search.net/ into Emanote. Footnotes
|
That's due to inline tag parser getting in the way: srid/emanote#167 A workaround would be to escape the Relevant issue: [\#275](https://github.com/Plutonomicon/plutarch/issues/275) |
... srid/emanote#167 is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful
rec { | ||
type = "app"; | ||
# '' is required for escaping ${} in nix | ||
script = (nixpkgsFor system).writers.writeBash "emanoteLiveReload.sh" '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this different from writeShellScriptBin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a copy-paste from plutonomicon, but now that you mention it I realize we should instead be using checkedShellScript
from the flake.
Adds
nix run .#docs
to run a live web view of docs locally. As well asnix run .#website
to build the static website. This is the same as what we do in https://github.com/Plutonomicon/plutonomicon - but using a newer version of Emanote containing support for the full range of relative links.The latter command also checks for broken links (the CI for this PR succeeds because those broken links have been fixed here).
Eventually, we can include Haddock generated HTML in the generated site of
nix run .#website
, before deploying it statically to GH pages using #393.