Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#903 import jakarta.validation instead of javax.validation #904

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

klu2
Copy link
Contributor

@klu2 klu2 commented May 26, 2022

in order to avoid duplicate classpath entries (jakarta.validation is already pulled transitively)

@klu2 klu2 changed the title #903 import jakarta.validation instead of javax.validation in order t… #903 import jakarta.validation instead of javax.validation May 26, 2022
@Aloren
Copy link
Contributor

Aloren commented May 27, 2022

jakarta validation is not supported by current spring boot, it requires spring boot 3.x.
spring-projects/spring-framework#25354

@klu2
Copy link
Contributor Author

klu2 commented May 29, 2022

the ticket you are refering to is talking about Jakarta EE 9, therefore about package changes. This is not the case here, The included JAR has the groupId jakarta.* and still package javax.*, so that's fine for Spring Boot 2.7. Still, as soon as Spring Boot goes to Jakarta EE 9, you will automatically get the new versions there with the jakarta.* packages, so that is future-proof, see https://spring.io/blog/2022/05/24/preparing-for-spring-boot-3-0

@klu2 klu2 mentioned this pull request Nov 28, 2022
@klu2 klu2 force-pushed the KL/use-jakarta branch 3 times, most recently from 0274a0b to 562a90b Compare December 2, 2022 15:24
… in order to avoid duplicate classpath entries
@Fameing Fameing merged commit 9deb23b into PlaytikaOSS:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants