Fix code scanning alert no. 15: Reflected cross-site scripting #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/PlayFab/thundernetes/security/code-scanning/15
To fix the reflected cross-site scripting vulnerability, we need to sanitize the user-controlled data before including it in the HTTP response. The best way to do this in Go is to use the
html.EscapeStringfunction from thehtmlpackage, which escapes special characters in a string to their corresponding HTML entities.We will update the
notFoundErrorfunction inpkg/operator/controllers/allocation_utils.goto escape themsgparameter before including it in the response. Additionally, we will ensure that other error-handling functions (internalServerError,badRequestError,tooManyRequestsError) also escape theirmsgparameters to prevent similar vulnerabilities.Suggested fixes powered by Copilot Autofix. Review carefully before merging.