Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small comment in W7X input file #999

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix small comment in W7X input file #999

merged 1 commit into from
Apr 18, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Apr 17, 2024

  • remove comment line in W7X input that is not true, add that having sequences for resolution will not trigger auto continuation

…for resolution will not trigger auto continuation
@dpanici dpanici added documentation Add documentation or better warnings etc. EZ-review labels Apr 17, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (f07e4cf) to head (990cefb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #999   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          87       87           
  Lines       22003    22003           
=======================================
  Hits        20886    20886           
  Misses       1117     1117           

Copy link
Contributor

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.89 +/- 2.68     | +1.55e-02 +/- 4.69e-02 |  1.77e+00 +/- 4.4e-02  |  1.75e+00 +/- 1.5e-02  |
 test_build_transform_fft_midres         |     +0.90 +/- 2.53     | +1.73e-02 +/- 4.85e-02 |  1.94e+00 +/- 2.4e-02  |  1.92e+00 +/- 4.2e-02  |
 test_build_transform_fft_highres        |     -0.16 +/- 1.28     | -3.71e-03 +/- 2.98e-02 |  2.32e+00 +/- 2.2e-02  |  2.33e+00 +/- 2.1e-02  |
 test_equilibrium_init_lowres            |     -0.22 +/- 1.05     | -2.08e-02 +/- 9.91e-02 |  9.39e+00 +/- 6.5e-02  |  9.41e+00 +/- 7.5e-02  |
 test_equilibrium_init_medres            |     -0.60 +/- 1.38     | -6.06e-02 +/- 1.40e-01 |  1.01e+01 +/- 7.0e-02  |  1.01e+01 +/- 1.2e-01  |
 test_equilibrium_init_highres           |     +0.67 +/- 1.58     | +7.92e-02 +/- 1.86e-01 |  1.19e+01 +/- 1.5e-01  |  1.18e+01 +/- 1.2e-01  |
 test_objective_compile_dshape_current   |     -0.10 +/- 9.41     | -3.75e-03 +/- 3.48e-01 |  3.69e+00 +/- 2.5e-01  |  3.70e+00 +/- 2.4e-01  |
 test_objective_compile_atf              |     -0.86 +/- 1.38     | -6.11e-02 +/- 9.77e-02 |  7.04e+00 +/- 6.8e-02  |  7.10e+00 +/- 7.0e-02  |
 test_objective_compute_dshape_current   |     -1.84 +/- 2.05     | -7.33e-05 +/- 8.16e-05 |  3.91e-03 +/- 4.0e-05  |  3.98e-03 +/- 7.1e-05  |
 test_objective_compute_atf              |     -0.92 +/- 1.99     | -1.61e-04 +/- 3.47e-04 |  1.73e-02 +/- 2.6e-04  |  1.74e-02 +/- 2.3e-04  |
 test_objective_jac_dshape_current       |     +0.63 +/- 7.32     | +2.60e-04 +/- 3.03e-03 |  4.17e-02 +/- 2.3e-03  |  4.14e-02 +/- 1.9e-03  |
 test_objective_jac_atf                  |     +2.34 +/- 3.54     | +4.22e-02 +/- 6.37e-02 |  1.84e+00 +/- 5.8e-02  |  1.80e+00 +/- 2.7e-02  |
 test_perturb_1                          |     -0.04 +/- 3.74     | -5.91e-03 +/- 5.24e-01 |  1.40e+01 +/- 4.0e-01  |  1.40e+01 +/- 3.4e-01  |
 test_perturb_2                          |     +0.26 +/- 2.92     | +4.82e-02 +/- 5.51e-01 |  1.89e+01 +/- 3.8e-01  |  1.88e+01 +/- 4.0e-01  |
 test_proximal_jac_atf                   |     -1.39 +/- 1.15     | -9.95e-02 +/- 8.25e-02 |  7.07e+00 +/- 6.1e-02  |  7.17e+00 +/- 5.6e-02  |
 test_proximal_freeb_compute             |     +0.46 +/- 1.08     | +5.80e-04 +/- 1.37e-03 |  1.27e-01 +/- 9.7e-04  |  1.27e-01 +/- 9.7e-04  |
 test_proximal_freeb_jac                 |     -0.41 +/- 1.08     | -2.94e-02 +/- 7.76e-02 |  7.14e+00 +/- 5.1e-02  |  7.17e+00 +/- 5.9e-02  |

@dpanici dpanici merged commit b10f8c8 into master Apr 18, 2024
22 checks passed
@f0uriest f0uriest deleted the dp/fix-input-file branch July 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add documentation or better warnings etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants