Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smallest PR ever #939

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Smallest PR ever #939

merged 1 commit into from
Mar 15, 2024

Conversation

YigitElma
Copy link
Collaborator

No description provided.

@YigitElma YigitElma requested a review from f0uriest March 15, 2024 18:43
@YigitElma YigitElma changed the title fix typo in the test_optimal_perturb Smallest PR ever Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (a232c02) to head (3ea31b9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files          86       86           
  Lines       21198    21198           
=======================================
  Hits        20078    20078           
  Misses       1120     1120           

Copy link
Contributor

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +1.32 +/- 2.88     | +1.22e-04 +/- 2.66e-04 |  9.35e-03 +/- 1.5e-04  |  9.22e-03 +/- 2.2e-04  |
 test_build_transform_fft_midres         |     +0.70 +/- 1.07     | +6.14e-04 +/- 9.36e-04 |  8.85e-02 +/- 6.8e-04  |  8.79e-02 +/- 6.4e-04  |
 test_build_transform_fft_highres        |     +1.73 +/- 1.06     | +7.83e-03 +/- 4.78e-03 |  4.61e-01 +/- 4.2e-03  |  4.53e-01 +/- 2.4e-03  |
 test_equilibrium_init_lowres            |     +1.46 +/- 2.24     | +3.88e-03 +/- 5.97e-03 |  2.70e-01 +/- 4.0e-03  |  2.66e-01 +/- 4.4e-03  |
 test_equilibrium_init_medres            |     -0.09 +/- 1.83     | -5.26e-04 +/- 1.11e-02 |  6.06e-01 +/- 6.8e-03  |  6.07e-01 +/- 8.8e-03  |
 test_equilibrium_init_highres           |     +0.50 +/- 1.46     | +1.09e-02 +/- 3.19e-02 |  2.20e+00 +/- 2.3e-02  |  2.18e+00 +/- 2.2e-02  |
 test_objective_compile_dshape_current   |     +1.88 +/- 8.63     | +7.47e-02 +/- 3.43e-01 |  4.05e+00 +/- 2.8e-01  |  3.98e+00 +/- 2.0e-01  |
 test_objective_compile_atf              |     +1.83 +/- 4.43     | +1.42e-01 +/- 3.45e-01 |  7.94e+00 +/- 2.5e-01  |  7.79e+00 +/- 2.4e-01  |
 test_objective_compute_dshape_current   |     -2.20 +/- 5.66     | -1.19e-04 +/- 3.06e-04 |  5.29e-03 +/- 1.0e-04  |  5.41e-03 +/- 2.9e-04  |
 test_objective_compute_atf              |     -0.40 +/- 3.99     | -4.57e-05 +/- 4.54e-04 |  1.13e-02 +/- 3.9e-04  |  1.14e-02 +/- 2.2e-04  |
 test_objective_jac_dshape_current       |     +1.76 +/- 5.71     | +7.86e-04 +/- 2.56e-03 |  4.56e-02 +/- 2.2e-03  |  4.48e-02 +/- 1.3e-03  |
 test_objective_jac_atf                  |     -0.54 +/- 2.39     | -1.13e-02 +/- 5.00e-02 |  2.08e+00 +/- 4.3e-02  |  2.09e+00 +/- 2.6e-02  |
 test_perturb_1                          |     +1.61 +/- 3.10     | +2.55e-01 +/- 4.90e-01 |  1.61e+01 +/- 2.8e-01  |  1.58e+01 +/- 4.0e-01  |
 test_perturb_2                          |     +3.20 +/- 2.62     | +6.73e-01 +/- 5.51e-01 |  2.17e+01 +/- 5.0e-01  |  2.10e+01 +/- 2.4e-01  |
 test_proximal_jac_atf                   |     +0.01 +/- 1.65     | +5.35e-04 +/- 1.18e-01 |  7.14e+00 +/- 7.2e-02  |  7.14e+00 +/- 9.4e-02  |
 test_proximal_freeb_compute             |     -0.93 +/- 0.96     | -1.16e-03 +/- 1.20e-03 |  1.25e-01 +/- 1.0e-03  |  1.26e-01 +/- 6.3e-04  |
 test_proximal_freeb_jac                 |     -0.57 +/- 1.42     | -4.07e-02 +/- 1.01e-01 |  7.06e+00 +/- 6.2e-02  |  7.10e+00 +/- 7.9e-02  |

@YigitElma YigitElma merged commit 072f66b into master Mar 15, 2024
17 checks passed
@YigitElma YigitElma deleted the yge/hotfix branch March 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants