-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add to CONTRIBUTING.rst how to update master compute data #922
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
877b3e4
add to CONTRIBUTING.rst how to update master compute data
dpanici bb3b934
Merge branch 'master' into dp/docs-update-data
f0uriest 4909611
fix some formatting
dpanici f34571a
Merge branch 'dp/docs-update-data' of github.com:PlasmaControl/DESC i…
dpanici 53d4443
properly format the commands and code
dpanici d1420f0
fix code block formatting
dpanici 1076ff1
final wording fix
dpanici 7be240c
fix commas
dpanici 1adb2fe
Merge branch 'master' into dp/docs-update-data
dpanici 9c19e09
Merge branch 'master' into dp/docs-update-data
ddudt 1673099
Merge branch 'dp/docs-update-data' of github.com:PlasmaControl/DESC i…
dpanici 88c9560
Merge branch 'master' into dp/docs-update-data
f0uriest 79d7122
Merge branch 'master' into dp/docs-update-data
f0uriest 7e0dce7
Merge branch 'master' into dp/docs-update-data
f0uriest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this actually make the test fail? I don't think it will, but you still have to remember to add that new parameterization to the test as you explained. Also this applies to adding entirely new classes, not just new parameterizations of an existing class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also "parameterization" is missing a second "e"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my spelling of parametrization is right or at least is an accepted spelling: https://en.wikipedia.org/wiki/Parametrization_(geometry)#:~:text=Parametrization%20is%20a%20mathematical%20process,some%20independent%20quantities%20called%20parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and yea it does fail bc of this line in
test_compute_everything