Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix curvy bugs #840

Merged
merged 23 commits into from
Feb 8, 2024

update examples with private axis curve attributes

d25b289
Select commit
Loading
Failed to load commit list.
Merged

fix curvy bugs #840

update examples with private axis curve attributes
d25b289
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 30, 2024 in 0s

60.79% (-34.12%) compared to 546cac3

View this Pull Request on Codecov

60.79% (-34.12%) compared to 546cac3

Details

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (546cac3) 94.90% compared to head (d25b289) 60.79%.

❗ Current head d25b289 differs from pull request most recent head 983aeda. Consider uploading reports for the commit 983aeda to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #840       +/-   ##
===========================================
- Coverage   94.90%   60.79%   -34.12%     
===========================================
  Files          80       80               
  Lines       19600    19624       +24     
===========================================
- Hits        18602    11930     -6672     
- Misses        998     7694     +6696     
Files Coverage Δ
desc/compute/geom_utils.py 17.39% <0.00%> (-82.61%) ⬇️
desc/geometry/core.py 42.13% <62.50%> (-56.01%) ⬇️
desc/compute/_curve.py 18.73% <2.50%> (-80.68%) ⬇️

... and 65 files with indirect coverage changes