-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for optimizing multiple objects #604
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpanici
reviewed
Oct 19, 2023
dpanici
reviewed
Oct 19, 2023
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -8.61 +/- 6.57 | -2.54e-03 +/- 1.94e-03 | 2.69e-02 +/- 1.7e-03 | 2.95e-02 +/- 9.2e-04 |
test_build_transform_fft_midres | -11.92 +/- 4.98 | -2.01e-02 +/- 8.38e-03 | 1.48e-01 +/- 6.3e-03 | 1.68e-01 +/- 5.5e-03 |
test_build_transform_fft_highres | -9.08 +/- 5.14 | -6.95e-02 +/- 3.93e-02 | 6.96e-01 +/- 2.3e-02 | 7.65e-01 +/- 3.2e-02 |
test_equilibrium_init_lowres | -5.04 +/- 4.55 | -3.08e-02 +/- 2.78e-02 | 5.80e-01 +/- 1.8e-02 | 6.11e-01 +/- 2.1e-02 |
test_equilibrium_init_medres | -7.92 +/- 7.02 | -6.29e-02 +/- 5.57e-02 | 7.30e-01 +/- 2.0e-02 | 7.93e-01 +/- 5.2e-02 |
test_equilibrium_init_highres | -6.42 +/- 3.88 | -8.24e-02 +/- 4.98e-02 | 1.20e+00 +/- 1.9e-02 | 1.28e+00 +/- 4.6e-02 |
test_objective_compile_dshape_current | -4.87 +/- 6.35 | -3.54e-01 +/- 4.61e-01 | 6.91e+00 +/- 3.2e-01 | 7.26e+00 +/- 3.3e-01 |
test_objective_compile_atf | +2.60 +/- 5.65 | +5.18e-01 +/- 1.13e+00 | 2.05e+01 +/- 7.7e-01 | 1.99e+01 +/- 8.3e-01 |
test_objective_compute_dshape_current | -4.15 +/- 11.18 | -1.65e-04 +/- 4.46e-04 | 3.82e-03 +/- 2.6e-04 | 3.99e-03 +/- 3.6e-04 |
test_objective_compute_atf | +1.15 +/- 6.02 | +1.49e-04 +/- 7.75e-04 | 1.30e-02 +/- 5.4e-04 | 1.29e-02 +/- 5.6e-04 |
test_objective_jac_dshape_current | +3.23 +/- 24.82 | +3.79e-03 +/- 2.91e-02 | 1.21e-01 +/- 6.8e-03 | 1.17e-01 +/- 2.8e-02 |
-test_objective_jac_atf | +7.82 +/- 2.42 | +6.20e-01 +/- 1.92e-01 | 8.54e+00 +/- 9.7e-02 | 7.92e+00 +/- 1.6e-01 |
test_perturb_1 | +24.40 +/- 13.11 | +2.88e+00 +/- 1.55e+00 | 1.47e+01 +/- 1.1e+00 | 1.18e+01 +/- 1.1e+00 |
test_perturb_2 | +15.39 +/- 8.94 | +3.41e+00 +/- 1.98e+00 | 2.56e+01 +/- 1.7e+00 | 2.21e+01 +/- 9.5e-01 | |
dpanici
reviewed
Oct 19, 2023
dpanici
reviewed
Oct 20, 2023
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +4.48 +/- 5.05 | +9.85e-04 +/- 1.11e-03 | 2.30e-02 +/- 9.5e-04 | 2.20e-02 +/- 5.7e-04 |
test_build_transform_fft_midres | +2.02 +/- 8.58 | +2.65e-03 +/- 1.12e-02 | 1.34e-01 +/- 9.7e-04 | 1.31e-01 +/- 1.1e-02 |
test_build_transform_fft_highres | +5.65 +/- 4.73 | +3.38e-02 +/- 2.83e-02 | 6.32e-01 +/- 2.4e-02 | 5.98e-01 +/- 1.5e-02 |
test_equilibrium_init_lowres | +3.38 +/- 5.27 | +1.71e-02 +/- 2.66e-02 | 5.22e-01 +/- 1.4e-02 | 5.05e-01 +/- 2.2e-02 |
test_equilibrium_init_medres | +0.66 +/- 11.66 | +4.34e-03 +/- 7.64e-02 | 6.60e-01 +/- 3.7e-02 | 6.56e-01 +/- 6.7e-02 |
test_equilibrium_init_highres | -0.99 +/- 6.07 | -1.16e-02 +/- 7.09e-02 | 1.16e+00 +/- 6.2e-02 | 1.17e+00 +/- 3.5e-02 |
test_objective_compile_dshape_current | +2.10 +/- 4.00 | +1.28e-01 +/- 2.43e-01 | 6.19e+00 +/- 1.3e-01 | 6.07e+00 +/- 2.1e-01 |
test_objective_compile_atf | +3.82 +/- 6.05 | +6.49e-01 +/- 1.03e+00 | 1.76e+01 +/- 6.4e-01 | 1.70e+01 +/- 8.0e-01 |
+test_objective_compute_dshape_current | -10.71 +/- 2.76 | -4.71e-04 +/- 1.21e-04 | 3.93e-03 +/- 6.3e-05 | 4.40e-03 +/- 1.0e-04 |
test_objective_compute_atf | -7.01 +/- 3.82 | -9.75e-04 +/- 5.31e-04 | 1.29e-02 +/- 3.1e-04 | 1.39e-02 +/- 4.3e-04 |
test_objective_jac_dshape_current | +0.02 +/- 8.57 | +2.95e-05 +/- 1.32e-02 | 1.54e-01 +/- 1.2e-02 | 1.54e-01 +/- 6.0e-03 |
test_objective_jac_atf | +12.19 +/- 5.94 | +8.55e-01 +/- 4.17e-01 | 7.87e+00 +/- 3.1e-01 | 7.02e+00 +/- 2.8e-01 |
test_perturb_1 | +15.53 +/- 9.24 | +1.67e+00 +/- 9.93e-01 | 1.24e+01 +/- 7.0e-01 | 1.07e+01 +/- 7.0e-01 |
test_perturb_2 | +13.28 +/- 12.24 | +2.54e+00 +/- 2.34e+00 | 2.17e+01 +/- 1.5e+00 | 1.91e+01 +/- 1.8e+00 | |
…ual list and util function were not in same order
dpanici
previously approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good, I cannot think of any other tests I want to do with it that don't involve some further functionality, so I am happy to merge into master once @ddudt also reviews
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -6.71 +/- 7.43 | -1.69e-03 +/- 1.88e-03 | 2.36e-02 +/- 1.1e-03 | 2.52e-02 +/- 1.5e-03 |
test_build_transform_fft_midres | -15.20 +/- 16.07 | -2.23e-02 +/- 2.36e-02 | 1.24e-01 +/- 9.5e-03 | 1.47e-01 +/- 2.2e-02 |
test_build_transform_fft_highres | -4.66 +/- 7.09 | -2.84e-02 +/- 4.33e-02 | 5.81e-01 +/- 3.8e-02 | 6.10e-01 +/- 2.0e-02 |
test_equilibrium_init_lowres | -1.29 +/- 7.21 | -6.55e-03 +/- 3.66e-02 | 5.02e-01 +/- 2.9e-02 | 5.08e-01 +/- 2.2e-02 |
test_equilibrium_init_medres | -2.38 +/- 6.37 | -1.53e-02 +/- 4.10e-02 | 6.28e-01 +/- 2.4e-02 | 6.43e-01 +/- 3.3e-02 |
test_equilibrium_init_highres | -0.70 +/- 8.79 | -7.43e-03 +/- 9.29e-02 | 1.05e+00 +/- 6.6e-02 | 1.06e+00 +/- 6.6e-02 |
test_objective_compile_dshape_current | -4.14 +/- 5.17 | -2.54e-01 +/- 3.17e-01 | 5.88e+00 +/- 2.1e-01 | 6.14e+00 +/- 2.4e-01 |
test_objective_compile_atf | +2.26 +/- 7.70 | +3.85e-01 +/- 1.31e+00 | 1.74e+01 +/- 8.4e-01 | 1.70e+01 +/- 1.0e+00 |
test_objective_compute_dshape_current | +1.90 +/- 11.71 | +6.50e-05 +/- 4.01e-04 | 3.49e-03 +/- 3.4e-04 | 3.42e-03 +/- 2.1e-04 |
test_objective_compute_atf | +5.60 +/- 8.32 | +6.35e-04 +/- 9.44e-04 | 1.20e-02 +/- 5.2e-04 | 1.13e-02 +/- 7.9e-04 |
test_objective_jac_dshape_current | +8.55 +/- 9.99 | +8.72e-03 +/- 1.02e-02 | 1.11e-01 +/- 8.4e-03 | 1.02e-01 +/- 5.8e-03 |
test_objective_jac_atf | +9.17 +/- 4.61 | +6.21e-01 +/- 3.12e-01 | 7.39e+00 +/- 1.2e-01 | 6.77e+00 +/- 2.9e-01 |
test_perturb_1 | +21.02 +/- 13.59 | +2.13e+00 +/- 1.38e+00 | 1.23e+01 +/- 9.2e-01 | 1.01e+01 +/- 1.0e+00 |
test_perturb_2 | +14.44 +/- 8.94 | +2.72e+00 +/- 1.69e+00 | 2.16e+01 +/- 1.1e+00 | 1.89e+01 +/- 1.2e+00 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -0.16 +/- 1.25 | -2.90e-05 +/- 2.31e-04 | 1.84e-02 +/- 1.7e-04 | 1.84e-02 +/- 1.6e-04 |
test_build_transform_fft_midres | +2.07 +/- 0.70 | +2.32e-03 +/- 7.82e-04 | 1.14e-01 +/- 5.6e-04 | 1.12e-01 +/- 5.5e-04 |
test_build_transform_fft_highres | +0.28 +/- 0.87 | +1.50e-03 +/- 4.61e-03 | 5.30e-01 +/- 2.9e-03 | 5.28e-01 +/- 3.6e-03 |
test_equilibrium_init_lowres | -0.64 +/- 1.54 | -2.66e-03 +/- 6.35e-03 | 4.11e-01 +/- 3.5e-03 | 4.13e-01 +/- 5.3e-03 |
test_equilibrium_init_medres | -0.40 +/- 1.68 | -2.11e-03 +/- 8.88e-03 | 5.26e-01 +/- 7.6e-03 | 5.28e-01 +/- 4.6e-03 |
test_equilibrium_init_highres | -0.04 +/- 1.15 | -3.57e-04 +/- 1.10e-02 | 9.57e-01 +/- 9.1e-03 | 9.57e-01 +/- 6.2e-03 |
test_objective_compile_dshape_current | -1.42 +/- 5.22 | -7.25e-02 +/- 2.67e-01 | 5.03e+00 +/- 1.8e-01 | 5.11e+00 +/- 2.0e-01 |
test_objective_compile_atf | +5.26 +/- 5.19 | +7.15e-01 +/- 7.04e-01 | 1.43e+01 +/- 4.0e-01 | 1.36e+01 +/- 5.8e-01 |
test_objective_compute_dshape_current | -0.31 +/- 2.08 | -9.70e-06 +/- 6.57e-05 | 3.15e-03 +/- 4.5e-05 | 3.16e-03 +/- 4.8e-05 |
test_objective_compute_atf | -2.11 +/- 1.49 | -2.31e-04 +/- 1.64e-04 | 1.07e-02 +/- 1.5e-04 | 1.10e-02 +/- 6.1e-05 |
test_objective_jac_dshape_current | +3.99 +/- 8.48 | +5.15e-03 +/- 1.09e-02 | 1.34e-01 +/- 7.8e-03 | 1.29e-01 +/- 7.6e-03 |
test_objective_jac_atf | +9.01 +/- 3.25 | +5.01e-01 +/- 1.80e-01 | 6.05e+00 +/- 9.3e-02 | 5.55e+00 +/- 1.5e-01 |
test_perturb_1 | +23.78 +/- 13.19 | +1.96e+00 +/- 1.09e+00 | 1.02e+01 +/- 7.1e-01 | 8.26e+00 +/- 8.2e-01 |
test_perturb_2 | +13.80 +/- 7.06 | +2.12e+00 +/- 1.08e+00 | 1.75e+01 +/- 3.6e-01 | 1.53e+01 +/- 1.0e+00 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -6.26 +/- 10.05 | -1.68e-03 +/- 2.70e-03 | 2.52e-02 +/- 1.4e-03 | 2.69e-02 +/- 2.3e-03 |
test_build_transform_fft_midres | -13.09 +/- 8.42 | -2.10e-02 +/- 1.35e-02 | 1.40e-01 +/- 6.1e-03 | 1.61e-01 +/- 1.2e-02 |
test_build_transform_fft_highres | -5.58 +/- 5.29 | -4.11e-02 +/- 3.90e-02 | 6.96e-01 +/- 2.9e-02 | 7.37e-01 +/- 2.6e-02 |
test_equilibrium_init_lowres | -0.17 +/- 5.90 | -9.87e-04 +/- 3.41e-02 | 5.78e-01 +/- 2.2e-02 | 5.79e-01 +/- 2.6e-02 |
test_equilibrium_init_medres | -1.51 +/- 6.08 | -1.07e-02 +/- 4.32e-02 | 7.00e-01 +/- 2.7e-02 | 7.11e-01 +/- 3.4e-02 |
test_equilibrium_init_highres | -1.29 +/- 3.58 | -1.52e-02 +/- 4.22e-02 | 1.16e+00 +/- 2.8e-02 | 1.18e+00 +/- 3.1e-02 |
test_objective_compile_dshape_current | -0.93 +/- 5.33 | -6.24e-02 +/- 3.58e-01 | 6.66e+00 +/- 3.1e-01 | 6.72e+00 +/- 1.8e-01 |
test_objective_compile_atf | +1.59 +/- 3.70 | +2.92e-01 +/- 6.80e-01 | 1.87e+01 +/- 6.1e-01 | 1.84e+01 +/- 2.9e-01 |
test_objective_compute_dshape_current | -4.01 +/- 9.95 | -1.44e-04 +/- 3.57e-04 | 3.45e-03 +/- 2.5e-04 | 3.59e-03 +/- 2.6e-04 |
test_objective_compute_atf | -3.39 +/- 9.41 | -4.42e-04 +/- 1.23e-03 | 1.26e-02 +/- 6.8e-04 | 1.30e-02 +/- 1.0e-03 |
test_objective_jac_dshape_current | -1.00 +/- 12.70 | -1.16e-03 +/- 1.47e-02 | 1.15e-01 +/- 9.8e-03 | 1.16e-01 +/- 1.1e-02 |
-test_objective_jac_atf | +13.37 +/- 3.29 | +8.85e-01 +/- 2.18e-01 | 7.50e+00 +/- 2.1e-01 | 6.62e+00 +/- 7.0e-02 |
test_perturb_1 | +21.40 +/- 9.16 | +2.50e+00 +/- 1.07e+00 | 1.42e+01 +/- 7.2e-01 | 1.17e+01 +/- 7.9e-01 |
test_perturb_2 | +14.10 +/- 9.09 | +3.02e+00 +/- 1.95e+00 | 2.44e+01 +/- 1.6e+00 | 2.14e+01 +/- 1.1e+00 | |
dpanici
dismissed
their stale review
October 24, 2023 16:14
waiting for the comments I made to be addressed (mainly the couple typos)
dpanici
approved these changes
Oct 24, 2023
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -0.54 +/- 1.67 | -1.04e-04 +/- 3.24e-04 | 1.93e-02 +/- 2.1e-04 | 1.94e-02 +/- 2.4e-04 |
-test_build_transform_fft_midres | +2.69 +/- 0.80 | +3.01e-03 +/- 8.97e-04 | 1.15e-01 +/- 4.5e-04 | 1.12e-01 +/- 7.8e-04 |
test_build_transform_fft_highres | +2.87 +/- 1.17 | +1.47e-02 +/- 6.03e-03 | 5.28e-01 +/- 4.1e-03 | 5.13e-01 +/- 4.4e-03 |
test_equilibrium_init_lowres | -0.02 +/- 1.23 | -2.00e-04 +/- 1.05e-02 | 8.53e-01 +/- 6.0e-03 | 8.53e-01 +/- 8.6e-03 |
test_equilibrium_init_medres | +0.08 +/- 0.99 | +1.03e-03 +/- 1.26e-02 | 1.27e+00 +/- 1.1e-02 | 1.27e+00 +/- 6.7e-03 |
test_equilibrium_init_highres | +1.03 +/- 0.51 | +3.12e-02 +/- 1.54e-02 | 3.06e+00 +/- 1.3e-02 | 3.03e+00 +/- 8.5e-03 |
test_objective_compile_dshape_current | -0.02 +/- 6.98 | -1.17e-03 +/- 3.72e-01 | 5.32e+00 +/- 2.6e-01 | 5.32e+00 +/- 2.7e-01 |
test_objective_compile_atf | +5.58 +/- 4.87 | +8.58e-01 +/- 7.49e-01 | 1.62e+01 +/- 4.8e-01 | 1.54e+01 +/- 5.7e-01 |
test_objective_compute_dshape_current | -1.38 +/- 10.13 | -4.66e-05 +/- 3.43e-04 | 3.33e-03 +/- 3.4e-04 | 3.38e-03 +/- 4.5e-05 |
test_objective_compute_atf | -0.55 +/- 2.09 | -6.22e-05 +/- 2.38e-04 | 1.13e-02 +/- 1.8e-04 | 1.14e-02 +/- 1.5e-04 |
test_objective_jac_dshape_current | +10.13 +/- 15.28 | +1.31e-02 +/- 1.97e-02 | 1.42e-01 +/- 1.6e-02 | 1.29e-01 +/- 1.1e-02 |
-test_objective_jac_atf | +9.08 +/- 2.81 | +6.08e-01 +/- 1.88e-01 | 7.30e+00 +/- 1.5e-01 | 6.69e+00 +/- 1.1e-01 |
test_perturb_1 | +23.89 +/- 15.09 | +2.10e+00 +/- 1.33e+00 | 1.09e+01 +/- 9.0e-01 | 8.78e+00 +/- 9.7e-01 |
test_perturb_2 | +12.65 +/- 6.26 | +2.11e+00 +/- 1.04e+00 | 1.88e+01 +/- 6.2e-01 | 1.67e+01 +/- 8.4e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | +0.99 +/- 1.73 | +1.81e-04 +/- 3.17e-04 | 1.85e-02 +/- 2.8e-04 | 1.83e-02 +/- 1.4e-04 |
test_build_transform_fft_midres | +1.79 +/- 0.86 | +1.99e-03 +/- 9.59e-04 | 1.13e-01 +/- 7.4e-04 | 1.11e-01 +/- 6.1e-04 |
test_build_transform_fft_highres | +0.72 +/- 0.58 | +3.75e-03 +/- 3.04e-03 | 5.26e-01 +/- 1.4e-03 | 5.23e-01 +/- 2.7e-03 |
test_equilibrium_init_lowres | +1.33 +/- 1.02 | +1.03e-02 +/- 7.91e-03 | 7.89e-01 +/- 4.9e-03 | 7.79e-01 +/- 6.2e-03 |
test_equilibrium_init_medres | +1.11 +/- 1.10 | +1.31e-02 +/- 1.31e-02 | 1.20e+00 +/- 1.1e-02 | 1.19e+00 +/- 7.5e-03 |
test_equilibrium_init_highres | +0.65 +/- 0.98 | +1.94e-02 +/- 2.92e-02 | 2.99e+00 +/- 2.2e-02 | 2.97e+00 +/- 1.9e-02 |
test_objective_compile_dshape_current | +1.00 +/- 6.14 | +5.05e-02 +/- 3.09e-01 | 5.08e+00 +/- 2.1e-01 | 5.03e+00 +/- 2.3e-01 |
test_objective_compile_atf | +6.57 +/- 4.75 | +8.97e-01 +/- 6.49e-01 | 1.46e+01 +/- 5.4e-01 | 1.37e+01 +/- 3.6e-01 |
test_objective_compute_dshape_current | +0.46 +/- 1.87 | +1.46e-05 +/- 5.88e-05 | 3.16e-03 +/- 4.0e-05 | 3.15e-03 +/- 4.4e-05 |
test_objective_compute_atf | +2.02 +/- 1.87 | +2.20e-04 +/- 2.03e-04 | 1.11e-02 +/- 1.9e-04 | 1.09e-02 +/- 5.9e-05 |
test_objective_jac_dshape_current | +7.29 +/- 6.11 | +9.35e-03 +/- 7.83e-03 | 1.38e-01 +/- 6.0e-03 | 1.28e-01 +/- 5.0e-03 |
test_objective_jac_atf | +10.47 +/- 5.26 | +5.70e-01 +/- 2.87e-01 | 6.02e+00 +/- 2.7e-01 | 5.45e+00 +/- 1.1e-01 |
test_perturb_1 | +25.83 +/- 12.75 | +2.13e+00 +/- 1.05e+00 | 1.04e+01 +/- 7.2e-01 | 8.24e+00 +/- 7.6e-01 |
-test_perturb_2 | +12.94 +/- 2.68 | +2.02e+00 +/- 4.18e-01 | 1.76e+01 +/- 3.5e-01 | 1.56e+01 +/- 2.3e-01 | |
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_lowres | -3.66 +/- 1.68 | -8.62e-04 +/- 3.94e-04 | 2.27e-02 +/- 2.7e-04 | 2.35e-02 +/- 2.9e-04 |
+test_build_transform_fft_midres | -4.82 +/- 0.66 | -6.73e-03 +/- 9.28e-04 | 1.33e-01 +/- 4.4e-04 | 1.40e-01 +/- 8.2e-04 |
+test_build_transform_fft_highres | -3.28 +/- 0.91 | -2.08e-02 +/- 5.75e-03 | 6.13e-01 +/- 4.0e-03 | 6.33e-01 +/- 4.1e-03 |
test_equilibrium_init_lowres | -0.84 +/- 1.67 | -8.40e-03 +/- 1.67e-02 | 9.93e-01 +/- 1.2e-02 | 1.00e+00 +/- 1.2e-02 |
test_equilibrium_init_medres | -2.36 +/- 1.27 | -3.58e-02 +/- 1.92e-02 | 1.48e+00 +/- 1.3e-02 | 1.51e+00 +/- 1.4e-02 |
+test_equilibrium_init_highres | -3.26 +/- 0.80 | -1.20e-01 +/- 2.94e-02 | 3.55e+00 +/- 2.3e-02 | 3.67e+00 +/- 1.8e-02 |
test_objective_compile_dshape_current | -1.29 +/- 6.40 | -8.09e-02 +/- 4.01e-01 | 6.18e+00 +/- 2.5e-01 | 6.26e+00 +/- 3.1e-01 |
test_objective_compile_atf | +3.74 +/- 4.11 | +6.70e-01 +/- 7.36e-01 | 1.86e+01 +/- 5.0e-01 | 1.79e+01 +/- 5.4e-01 |
test_objective_compute_dshape_current | -1.08 +/- 2.53 | -4.34e-05 +/- 1.02e-04 | 3.98e-03 +/- 7.2e-05 | 4.02e-03 +/- 7.2e-05 |
test_objective_compute_atf | -0.52 +/- 1.16 | -7.00e-05 +/- 1.56e-04 | 1.34e-02 +/- 1.4e-04 | 1.35e-02 +/- 6.6e-05 |
test_objective_jac_dshape_current | +13.06 +/- 9.85 | +1.98e-02 +/- 1.50e-02 | 1.72e-01 +/- 1.4e-02 | 1.52e-01 +/- 6.4e-03 |
-test_objective_jac_atf | +8.90 +/- 2.67 | +6.75e-01 +/- 2.03e-01 | 8.26e+00 +/- 1.3e-01 | 7.58e+00 +/- 1.5e-01 |
test_perturb_1 | +24.83 +/- 14.68 | +2.57e+00 +/- 1.52e+00 | 1.29e+01 +/- 9.8e-01 | 1.03e+01 +/- 1.2e+00 |
test_perturb_2 | +12.72 +/- 4.50 | +2.51e+00 +/- 8.86e-01 | 2.22e+01 +/- 4.3e-01 | 1.97e+01 +/- 7.8e-01 | |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this PR:
things
- can probably come up with a better nameFor a future PR:
CoilSets
ProximalProjection
is still limited to just the equilibrium, we could possibly generalize that?MeanCurvature
withFourierRZToroidalSurface
)Resolves #560
Resolves #561