Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action for checking changelog updates #1358

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Add action for checking changelog updates #1358

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
056f0b7
Add action for checking changelog updates
f0uriest Nov 12, 2024
5ed344a
Fix if syntax
f0uriest Nov 12, 2024
57f94f3
Fix getting labels
f0uriest Nov 12, 2024
9906f9e
Trying again
f0uriest Nov 12, 2024
318033b
Refactor to only skip step not whole job
f0uriest Nov 12, 2024
4fb1535
Merge branch 'master' into rc/changelog
YigitElma Nov 12, 2024
e6177b6
Add filter
f0uriest Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/changelog_update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Check changelog updated

on:
pull_request:
branches:
- master
types: [opened, synchronize, labeled, unlabeled]

jobs:
check_changelog_updated:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip_changelog') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding filter for changed files could save time here

- name: Filter changes
        id: changes
        uses: dorny/paths-filter@v3
        with:
          filters: |
            has_changes:
              - 'desc/**'

For the changelog, we don't want to include the changes in other folders anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole action takes a few seconds so don't think its really worth it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By time, I mean adding the flag. If this test runs for every PR and fails, then that small red cross could be annoying :)

uses: danieljimeneznz/[email protected]
with:
require-changes-to: |
CHANGELOG.md
token: ${{ secrets.GITHUB_TOKEN }}