-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make map_coordinates
differentiable for JAX 0.4.34
#1293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiply by all dots
YigitElma
added
test_jax
Run tests against different versions of JAX
easy
Short and simple to code or review
bug fix
Something was fixed
labels
Oct 4, 2024
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_midres | +1.10 +/- 3.45 | +6.73e-03 +/- 2.11e-02 | 6.19e-01 +/- 1.8e-02 | 6.12e-01 +/- 1.0e-02 |
test_build_transform_fft_highres | +0.04 +/- 2.56 | +3.64e-04 +/- 2.59e-02 | 1.01e+00 +/- 2.1e-02 | 1.01e+00 +/- 1.5e-02 |
test_equilibrium_init_lowres | +1.28 +/- 1.35 | +4.96e-02 +/- 5.23e-02 | 3.92e+00 +/- 3.3e-02 | 3.87e+00 +/- 4.0e-02 |
test_objective_compile_atf | +0.43 +/- 4.17 | +3.33e-02 +/- 3.26e-01 | 7.86e+00 +/- 2.6e-01 | 7.82e+00 +/- 2.0e-01 |
test_objective_compute_atf | -0.22 +/- 2.94 | -2.32e-05 +/- 3.09e-04 | 1.05e-02 +/- 2.2e-04 | 1.05e-02 +/- 2.2e-04 |
test_objective_jac_atf | -1.93 +/- 2.33 | -3.75e-02 +/- 4.53e-02 | 1.91e+00 +/- 4.0e-02 | 1.95e+00 +/- 2.1e-02 |
test_perturb_1 | +0.31 +/- 2.35 | +3.92e-02 +/- 2.99e-01 | 1.27e+01 +/- 1.2e-01 | 1.27e+01 +/- 2.7e-01 |
test_proximal_jac_atf | +0.41 +/- 0.98 | +3.30e-02 +/- 7.94e-02 | 8.10e+00 +/- 3.5e-02 | 8.07e+00 +/- 7.1e-02 |
test_proximal_freeb_compute | +0.03 +/- 0.88 | +5.43e-05 +/- 1.61e-03 | 1.83e-01 +/- 1.3e-03 | 1.83e-01 +/- 9.1e-04 |
test_build_transform_fft_lowres | -7.38 +/- 7.18 | -4.11e-02 +/- 4.00e-02 | 5.16e-01 +/- 3.6e-02 | 5.57e-01 +/- 1.8e-02 |
test_equilibrium_init_medres | -3.06 +/- 8.60 | -1.28e-01 +/- 3.60e-01 | 4.05e+00 +/- 3.3e-02 | 4.18e+00 +/- 3.6e-01 |
test_equilibrium_init_highres | +0.00 +/- 1.40 | +2.00e-04 +/- 7.54e-02 | 5.38e+00 +/- 5.5e-02 | 5.38e+00 +/- 5.2e-02 |
test_objective_compile_dshape_current | +0.18 +/- 5.51 | +6.76e-03 +/- 2.10e-01 | 3.82e+00 +/- 2.1e-01 | 3.81e+00 +/- 4.1e-02 |
test_objective_compute_dshape_current | +0.27 +/- 2.30 | +9.61e-06 +/- 8.30e-05 | 3.61e-03 +/- 6.7e-05 | 3.60e-03 +/- 4.9e-05 |
test_objective_jac_dshape_current | -1.00 +/- 11.38 | -3.92e-04 +/- 4.47e-03 | 3.89e-02 +/- 3.2e-03 | 3.93e-02 +/- 3.1e-03 |
test_perturb_2 | +2.36 +/- 2.95 | +4.09e-01 +/- 5.12e-01 | 1.77e+01 +/- 1.4e-01 | 1.73e+01 +/- 4.9e-01 |
test_proximal_freeb_jac | -2.36 +/- 1.26 | -1.77e-01 +/- 9.50e-02 | 7.35e+00 +/- 6.7e-02 | 7.53e+00 +/- 6.7e-02 |
test_solve_fixed_iter | -1.16 +/- 57.77 | -5.85e-02 +/- 2.92e+00 | 4.99e+00 +/- 2.1e+00 | 5.05e+00 +/- 2.1e+00 | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1293 +/- ##
==========================================
- Coverage 95.52% 95.51% -0.02%
==========================================
Files 96 96
Lines 24010 24032 +22
==========================================
+ Hits 22936 22954 +18
- Misses 1074 1078 +4
|
dpanici
added
test_jax
Run tests against different versions of JAX
and removed
test_jax
Run tests against different versions of JAX
labels
Oct 5, 2024
dpanici
added
test_jax
Run tests against different versions of JAX
and removed
test_jax
Run tests against different versions of JAX
labels
Oct 6, 2024
dpanici
added
test_jax
Run tests against different versions of JAX
and removed
test_jax
Run tests against different versions of JAX
labels
Oct 6, 2024
…o yge/customjvp_fix
…rsion depende=ing on jax version to prevent errors
dpanici
added
test_jax
Run tests against different versions of JAX
and removed
test_jax
Run tests against different versions of JAX
labels
Oct 7, 2024
unalmis
previously approved these changes
Oct 28, 2024
YigitElma
dismissed stale reviews from f0uriest and dpanici
October 28, 2024 21:00
requested changes are made
YigitElma
requested review from
f0uriest,
dpanici,
rahulgaur104 and
ddudt
and removed request for
f0uriest,
rahulgaur104,
ddudt and
dpanici
October 28, 2024 21:02
f0uriest
previously approved these changes
Oct 28, 2024
ddudt
requested changes
Oct 28, 2024
unalmis
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f0uriest
approved these changes
Oct 30, 2024
unalmis
approved these changes
Oct 30, 2024
ddudt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
full_output
flags toroot
androot_scalar
to make them differentiable.Adds tests for differentiability of
root
androot_scalar
in addition tomap_coordinates_derivative
While working on jax problems, I used this PR to update our
test_jax
workflow with new jax versions and better dependency installation routine (i.e. previously since jax was uploaded later, rest of the packages were latest and only jax was old, this was causing incompatibilities and false-errors)Resolves #1291