Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FusionPower
objective #1220FusionPower
objective #1220Changes from 12 commits
25b5846
ed68131
0046524
eb0e22c
e28c794
9dabc7c
67abe7f
e4d783c
a085fde
a696633
21fcf3f
447f17e
3a0bbc4
60d61c9
fd6b57c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the most sensible default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good target will depend on the scale of the machine, but I changed it to 1,000 MW to be realistic for a power plant
Check warning on line 138 in desc/objectives/_power_balance.py
Codecov / codecov/patch
desc/objectives/_power_balance.py#L138
Check warning on line 165 in desc/objectives/_power_balance.py
Codecov / codecov/patch
desc/objectives/_power_balance.py#L165
Check warning on line 183 in desc/objectives/_power_balance.py
Codecov / codecov/patch
desc/objectives/_power_balance.py#L183
Check warning on line 186 in desc/objectives/_power_balance.py
Codecov / codecov/patch
desc/objectives/_power_balance.py#L186